Remove Control Reset on Send #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control inputs set will stay set until they are explicitly changed. I.e. you don't need to continually set the joystick at a certain value, it will just stay there until changed.
Since the array is no longer set to 0 after each send, this bit wasn't overwritten unless the dpad function was explicitly called.
|
Glad to hear everything is working for you as well! It doesn't look like this repo is being maintained, so I'm going to continue development as needed on my fork. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the control data reset that happens whenever the data is sent. The library now follows a more conventional "press/release" idiom, meaning that if you set a control surface it stays set up until you change it. E.g. if you set a joystick position it won't go back to 0 until you set it back to 0. This avoids having to write every possible control surface for every update, even if they don't change.
Because the array isn't cleared on every update, I also changed the "DPAD_UP" bit to "0" in the default array values. This way the controller won't hold the directional pad up if you don't overwrite the values.