Remove extRefresh cmd & FTP registration popup #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
JillieBeanSim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
==========================================
- Coverage 92.77% 92.76% -0.01%
==========================================
Files 113 113
Lines 11662 11650 -12
Branches 2491 2593 +102
==========================================
- Hits 10819 10807 -12
Misses 841 841
Partials 2 2 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Sep 23, 2024
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
|
📅 Suggested merge-by date: 10/7/2024 |
12 tasks
Signed-off-by: Billie Simmons <49491949+JillieBeanSim@users.noreply.github.com>
zFernand0
previously approved these changes
Sep 23, 2024
zFernand0
dismissed
their stale review
not sure if this is considered a breaking change and if we are ok with it 😋
|
@zFernand0 I presented the proposal with the v2 fix and it was discussed in scrum to remove the command in favor of the VSC command. |
Signed-off-by: Billie Simmons <BillieJean.Simmons@ibm.com>
JillieBeanSim
commented
Sep 24, 2024
| @@ -14,7 +14,7 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen | |||
| - Fix issue with extender profiles not being included in fresh team configuration file. [#3122](https://github.com/zowe/zowe-explorer-vscode/issues/3122) | |||
| - Fixed issue where file extensions were removed from data sets, causing language detection to sometimes fail for Zowe Explorer extenders. [#3121](https://github.com/zowe/zowe-explorer-vscode/issues/3121) | |||
| - Fixed an issue where copying and pasting a file/folder in the USS tree would fail abruptly, displaying an error. [#3128](https://github.com/zowe/zowe-explorer-vscode/issues/3128) | |||
| - To fix Strange behaviour of Job label under Job Favorites. [#2632](https://github.com/zowe/zowe-explorer-vscode/issues/2632) | |||
There was a problem hiding this comment.
removed, v2 port changelog
zFernand0
approved these changes
Sep 24, 2024
traeok
approved these changes
Sep 24, 2024
| await Gui.showMessage("Zowe Explorer was modified for FTP support.", { logger: globals.LOGGER }); | ||
| globals.LOGGER.logImperativeMessage("Zowe Explorer was modified for FTP support.", MessageSeverity.INFO); |
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix for #2862 & #3100
log writing can be found at
~/.vscode/extension/zowe.zowe-explorer-ftp-extension-3.0.0-next-SNAPSHOT/logsRelease Notes
Milestone: 3.0 GA
Changelog:
ZE - Removal of broken VSC command
Zowe Explorer: Refresh Zowe Explorer, use VS Code'sExtensions: Refreshcommand instead. #3100zFTP - Removed popup notification of successful registration with Zowe Explorer and log the success instead. #2862
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublishpnpm --filter vscode-extension-for-zowe vscode:prepublishCode coverage
Deployment
Further comments