Remove extRefresh cmd & FTP registration popup

packages/zowe-explorer-ftp-extension/CHANGELOG.md

@@ -6,6 +6,8 @@ All notable changes to the "zowe-explorer-ftp-extension" extension will be docum
 
 ### Bug fixes
 
+- Removed popup notification of successful registration with Zowe Explorer and log the success instead. [#2862](https://github.com/zowe/zowe-explorer-vscode/issues/2862)
+
 ## `3.0.0-next.202409132122`
 
 ### New features and enhancements

packages/zowe-explorer-ftp-extension/src/extension.ts

@@ -44,7 +44,7 @@ async function registerFtpApis(): Promise<boolean> {
         await zoweExplorerApi.getExplorerExtenderApi().initForZowe(pType, schema);
         await zoweExplorerApi.getExplorerExtenderApi().reloadProfiles(pType);
 
-        await Gui.showMessage("Zowe Explorer was modified for FTP support.", { logger: globals.LOGGER });
+        globals.LOGGER.logImperativeMessage("Zowe Explorer was modified for FTP support.", MessageSeverity.INFO);
 
         return true;
     }

packages/zowe-explorer/CHANGELOG.md

@@ -14,7 +14,7 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 - Fix issue with extender profiles not being included in fresh team configuration file. [#3122](https://github.com/zowe/zowe-explorer-vscode/issues/3122)
 - Fixed issue where file extensions were removed from data sets, causing language detection to sometimes fail for Zowe Explorer extenders. [#3121](https://github.com/zowe/zowe-explorer-vscode/issues/3121)
 - Fixed an issue where copying and pasting a file/folder in the USS tree would fail abruptly, displaying an error. [#3128](https://github.com/zowe/zowe-explorer-vscode/issues/3128)
-- To fix Strange behaviour of Job label under Job Favorites. [#2632](https://github.com/zowe/zowe-explorer-vscode/issues/2632)
+- Removal of broken VSC command to `Zowe Explorer: Refresh Zowe Explorer`, use VS Code's `Extensions: Refresh` command instead. [#3100](https://github.com/zowe/zowe-explorer-vscode/issues/3100)
 
 ## `3.0.0-next.202409132122`
 

packages/zowe-explorer/__tests__/__unit__/extension.unit.test.ts

@@ -242,7 +242,6 @@ async function createGlobalMocks() {
             "zowe.compareWithSelectedReadOnly",
             "zowe.compareFileStarted",
             "zowe.placeholderCommand",
-            "zowe.extRefresh",
         ],
     };
 

packages/zowe-explorer/__tests__/__unit__/trees/shared/SharedInit.unit.test.ts

@@ -18,7 +18,6 @@ import { Constants } from "../../../../src/configuration/Constants";
 import { Profiles } from "../../../../src/configuration/Profiles";
 import { SharedActions } from "../../../../src/trees/shared/SharedActions";
 import { LocalFileManagement } from "../../../../src/management/LocalFileManagement";
-import { ZoweLogger } from "../../../../src/tools/ZoweLogger";
 import { ZoweExplorerApiRegister } from "../../../../src/extending/ZoweExplorerApiRegister";
 import { SharedInit } from "../../../../src/trees/shared/SharedInit";
 import { TsoCommandHandler } from "../../../../src/commands/TsoCommandHandler";
@@ -319,44 +318,6 @@ describe("Test src/shared/extension", () => {
 
         processSubscriptions(commands, test);
     });
-    describe("registerRefreshCommand", () => {
-        const context: any = { subscriptions: [] };
-        const activate = jest.fn();
-        const deactivate = jest.fn();
-        const dispose = jest.fn();
-        let extRefreshCallback;
-        const spyExecuteCommand = jest.fn();
-
-        beforeAll(() => {
-            Object.defineProperty(vscode.commands, "registerCommand", {
-                value: (_: string, fun: () => void) => {
-                    extRefreshCallback = fun;
-                    return { dispose };
-                },
-            });
-            Object.defineProperty(vscode.commands, "executeCommand", { value: spyExecuteCommand });
-            SharedInit.registerRefreshCommand(context, activate, deactivate);
-        });
-
-        beforeEach(() => {
-            jest.clearAllMocks();
-        });
-
-        afterAll(() => {
-            jest.restoreAllMocks();
-        });
-
-        it("Test assuming we are unable to dispose of the subscription", async () => {
-            const testError = new Error("test");
-            dispose.mockRejectedValue(testError);
-            await extRefreshCallback();
-            expect(spyExecuteCommand).not.toHaveBeenCalled();
-            expect(deactivate).toHaveBeenCalled();
-            expect(ZoweLogger.error).toHaveBeenCalledWith(testError);
-            expect(dispose).toHaveBeenCalled();
-            expect(activate).toHaveBeenCalled();
-        });
-    });
 
     describe("watchConfigProfile", () => {
         let context: any;

packages/zowe-explorer/l10n/poeditor.json

@@ -29,9 +29,6 @@
   "zowe.profileManagement": {
     "Manage Profile": ""
   },
-  "zowe.extRefresh": {
-    "Refresh Zowe Explorer": ""
-  },
   "zowe.editHistory": {
     "Edit History": ""
   },

packages/zowe-explorer/package.json

@@ -111,11 +111,6 @@
         "key": "delete",
         "when": "focusedView == zowe.uss.explorer"
       },
-      {
-        "command": "zowe.extRefresh",
-        "key": "ctrl+alt+z",
-        "mac": "cmd+alt+z"
-      },
       {
         "command": "zowe.editHistory",
         "key": "ctrl+alt+y",
@@ -168,15 +163,6 @@
         "title": "%zowe.profileManagement%",
         "category": "Zowe Explorer"
       },
-      {
-        "command": "zowe.extRefresh",
-        "title": "%zowe.extRefresh%",
-        "category": "Zowe Explorer",
-        "icon": {
-          "light": "./resources/light/refresh.svg",
-          "dark": "./resources/dark/refresh.svg"
-        }
-      },
       {
         "command": "zowe.editHistory",
         "title": "%zowe.editHistory%",

packages/zowe-explorer/package.nls.json

@@ -9,7 +9,6 @@
   "zowe.placeholderCommand": "Placeholder",
   "zowe.promptCredentials": "Update Credentials",
   "zowe.profileManagement": "Manage Profile",
-  "zowe.extRefresh": "Refresh Zowe Explorer",
   "zowe.editHistory": "Edit History",
   "zowe.ds.explorer": "Data Sets",
   "zowe.uss.explorer": "Unix System Services (USS)",

packages/zowe-explorer/src/configuration/Constants.ts

@@ -17,7 +17,7 @@ import type { Profiles } from "./Profiles";
 
 export class Constants {
     public static CONFIG_PATH: string;
-    public static readonly COMMAND_COUNT = 100;
+    public static readonly COMMAND_COUNT = 99;
     public static readonly MAX_SEARCH_HISTORY = 5;
     public static readonly MAX_FILE_HISTORY = 10;
     public static readonly MS_PER_SEC = 1000;

packages/zowe-explorer/src/extension.ts

@@ -50,7 +50,6 @@ export async function activate(context: vscode.ExtensionContext): Promise<ZoweEx
     );
     SharedInit.registerCommonCommands(context, providers);
     SharedInit.registerZosConsoleView(context);
-    SharedInit.registerRefreshCommand(context, activate, deactivate);
     ZoweExplorerExtender.createInstance(providers.ds, providers.uss, providers.job);
 
     SharedInit.watchConfigProfile(context);

packages/zowe-explorer/src/trees/shared/SharedInit.ts

@@ -48,28 +48,6 @@ import { CertificateWizard } from "../../utils/CertificateWizard";
 import { ZosConsoleViewProvider } from "../../zosconsole/ZosConsolePanel";
 
 export class SharedInit {
-    public static registerRefreshCommand(
-        context: vscode.ExtensionContext,
-        activate: (_context: vscode.ExtensionContext) => Promise<ZoweExplorerApiRegister>,
-        deactivate: () => Promise<void>
-    ): void {
-        ZoweLogger.trace("shared.init.registerRefreshCommand called.");
-        // set a command to silently reload extension
-        context.subscriptions.push(
-            vscode.commands.registerCommand("zowe.extRefresh", async () => {
-                await deactivate();
-                for (const sub of context.subscriptions) {
-                    try {
-                        await sub.dispose();
-                    } catch (e) {
-                        ZoweLogger.error(e);
-                    }
-                }
-                await activate(context);
-            })
-        );
-    }
-
     public static registerCommonCommands(context: vscode.ExtensionContext, providers: Definitions.IZoweProviders): void {
         ZoweLogger.trace("shared.init.registerCommonCommands called.");