-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adapt to Swiftmailer 5 and Swiftmailer 6 version of class Swift_ConfigurableSpool #279
base: master
Are you sure you want to change the base?
Adapt to Swiftmailer 5 and Swiftmailer 6 version of class Swift_ConfigurableSpool #279
Conversation
+1 for symfony/mailer wrapper as a mailer plugin. |
For reference: #240 (comment) |
lib/plugins/sfDoctrinePlugin/lib/mailer/Swift_DoctrineSpool.class.php
Outdated
Show resolved
Hide resolved
2e2bd83
to
d6fc1b0
Compare
Do you have any experience, how to use the spool? I've thought about creating a test for it. While browsing the test sources, I've come across https://github.com/FriendsOfSymfony1/symfony1/blob/master/test/unit/mailer/fixtures/TestSpool.class.php which is referencing |
I am currently using Swfitmailer with spool under Symfony5. I can figure out how to set it up here. |
we might need to run the tests on the CI with --prefer-lowest to test both versions of the SwiftMailer, wdyt? |
@thirsch File(system) spool example configuration: factories.yml
|
Btw I found this about spools: |
@@ -71,9 +71,9 @@ public function stop() | |||
/** | |||
* Stores a message in the queue. | |||
* | |||
* @param Swift_Mime_Message $message The message to store | |||
* @param $message The message to store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param $message The message to store | |
* @param object $message The message to store |
wdyt @thirsch ?
Does it mean that the |
@thePanz as promised, here is a possible solution of the swiftmailer issue. What do you think?
Btw. as the swiftmailer package is discontinued but needs a small adjustment for php 8.2: Should we clone the official repo in fos1 as well or try to adapt to symfony/mailer?