Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor test files location #12

Closed
wants to merge 1 commit into from
Closed

Conversation

leo-ori
Copy link
Contributor

@leo-ori leo-ori commented Apr 17, 2024

Summary

Relocate test files (mock data and test) inside the src folder

Fixes

#10

Proposed changes

  • Move mockData folder to src/common/
  • Move test folder to src/
  • Add import 'jest-extended'; to index.ts to suppress errors for toIncludeAllMembers in JsonFormatter.tests.tsx
  • Fix tests:
    • Replace toString with JSON.stringify and use toMatch with regular expressions.
    • Remove unnecessary scaped chars

Test

  • Run all the tests yarn test
  • Make sure all tests pass

@leo-ori leo-ori added the A - Task Engineering Task label Apr 17, 2024
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced with #5, we will need to consider another solution as we don't want to intermix test with source when packaging the lib.

@doneill doneill mentioned this pull request Apr 19, 2024
@leo-ori
Copy link
Contributor Author

leo-ori commented Apr 19, 2024

Closed in favor of #13

@leo-ori leo-ori closed this Apr 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A - Task Engineering Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants