Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix lint errors #13

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Fix lint errors #13

merged 8 commits into from
Apr 22, 2024

Conversation

doneill
Copy link
Collaborator

@doneill doneill commented Apr 19, 2024 •
edited
Loading

Summary

Relocate test files (mock data and test) inside the src folder

Fixes

#10

Proposed changes

  • Fix linter configs
    • Ensure paths, includes/excludes support test/common location
  • Format configs
  • Format test file

Test

  • Open JsonFormatter.test.tsx, confirm linter errors are no longer displaying
  • Run all the tests yarn test
  • Make sure all tests pass

leo-ori
leo-ori reviewed Apr 19, 2024
View reviewed changes
Copy link
Contributor

@leo-ori leo-ori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment

@leo-ori leo-ori mentioned this pull request Apr 19, 2024
Closed
@doneill doneill self-assigned this Apr 19, 2024
@doneill doneill mentioned this pull request Apr 19, 2024
Closed
@doneill doneill merged commit eb0d10e into develop Apr 22, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leo-ori leo-ori leo-ori approved these changes

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

Assignees

@doneill doneill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doneill @leo-ori