[PS] Display fade overlay for locked skins

[moinm3uw]

https://trello.com/c/G8zgZpPx/926-ps-display-fade-overlay-for-locked-skins?filter=member:valeriirotermel

418413730-7b54060d-f92e-4c49-947f-7c7444ded8ce.mp4

[JanSeliv]

1. The main problem here: assigning = true at the end of ternary is mistake, you probably wanted the equality == operator instead, but mistakenly used assigning =
2. Please dont forget about const

Expected Result

Where I additionally further simplified the line by replacing ternary with simple condition, that is the same:

const bool bIsLastUnlockedFound = Count > 0 && MeshComp.IsSkinAvailable(Count) || bIsCurrentSkinAvailable;

[moinm3uw]

here I need to assign bIsCurrentSkinAvailable to true and then assign bIsLastUnlcokedUnlockedFound.
I can simplify reading this to something like:

Suggested change

	bool bIsLastUnlockedFound = Count > 0 ? MeshComp.IsSkinAvailable(Count) : bIsCurrentSkinAvailable = true;
	bool bIsLastUnlockedFound = false;
	if (Count > 0)
	{
	bIsLastUnlockedFound = MeshComp.IsSkinAvailable(Count);
	}
	else
	{
	bIsCurrentSkinAvailable = true;
	bIsLastUnlockedFound = bIsCurrentSkinAvailable;
	}

Let me know if I need to incorporate those changes.
by far const added as part of c1a8d9d

[JanSeliv]

@moinm3uw, current logic still looks overcomplicated. Please simplify it by removing the unused bIsCurrentSkinAvailable variable entirely, avoid assignments inside ternary, and replace the ternary with a clean inline condition using logical operators. This will improve clarity and prevent side effects that may confuse future readers.

Next simplified logic should do all the same as original:

// Skip if current skin is already available
if (MeshComp.IsSkinAvailable(CurrentSkinIndex))
{
	return;
}

// Find last available skin from current index downward
for (int32 Count = CurrentSkinIndex; Count >= 0; Count--)
{
	if (Count == 0 || MeshComp.IsSkinAvailable(Count))
	{
		MeshComp.ApplySkinByIndex(Count);

		constexpr bool bApplySkin = true;
		RefreshAmountOfUnlockedSkins(bApplySkin);
		break;
	}
}

[moinm3uw]

done 07bfc89

[moinm3uw]

recovered references after refactoring: