Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix minor error in else statement #73

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Fix minor error in else statement #73

merged 4 commits into from
Jan 30, 2020

Conversation

hamelsmu
Copy link
Contributor

The result of glob.glob(fname) is a List[str], which caused an error because later on expects List[Path]

Learned about this error when trying to reproduce fastai/fast_template#18

Without this fix will get this error:

AttributeError: 'str' object has no attribute 'name'

@hamelsmu hamelsmu requested a review from sgugger January 30, 2020 01:48
@sgugger
Copy link

sgugger commented Jan 30, 2020

Looking good to me, thanks for the fix!

@sgugger sgugger merged commit c420a89 into AnswerDotAI:master Jan 30, 2020
@hamelsmu hamelsmu mentioned this pull request Jan 30, 2020
sgugger added a commit that referenced this pull request Jan 31, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants