Fix Bug in #73 #76
Fix Bug in #73 #76
Conversation
| else: files = list(p.parent.glob(p.name)) | ||
| else: | ||
| p = Path(fname) | ||
| files = list(p.parent.glob(p.name)) |
There was a problem hiding this comment.
This was the bug. I forgot to include p = Path(fname). I realized that I didn't catch this error because I didn't have great tests. So I added some tests to this notebook.
|
I also turned on CI in my local repo and can verify the latest commit on this PR's branch it is passing
|
|
Thanks! I guess I should also have read more carefully ;) |
|
Follow-up question. Do you know if there is a way to automatically trigger the CI at each commit or at the least with an action form me before merging (like adding a special label)? That would help ensure these kinds of breaks don't happen. |
|
I’m looking into this now, will comment back on this thread when I find the best solution |
|
Opened #77 to address this |
@sgugger I introduced a bug in #73 🤦♂ . I am really sorry about this. To try to mitigate this from happening I added tests for
notebook2html. I am not 100% sure this is the way you want to see tests, but I tried to follow the conventions in the notebook carefully.Happy to amend this PR with any suggestions. 🙇 Thank you