Enable CI on Pull Requests #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Perfect! I don't want to necessarily protect the branch (as I sometimes want to merge things that fail and fix them myself) but this is great. Could you update the template as well? I'm going to push this to our other nbdev-generated repos. |
|
Sorry What do you mean by update the template? fast_template? |
|
nbdev_template (thanks again for all those PRs :) ) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sgugger this will help solve the problem to catch things like what happened in #73
You will also have to turn on branch protection. In settings, create a branch protection rule for the
masterbranch and checkRequire Status Checks To Pass Before Merging