Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sql server restructured #317

Merged
merged 13 commits into from
Nov 3, 2021
Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 30, 2021

Change

  • Restructured SQL server to child-resource structure

Pipeline reference:
Sql: Servers

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr self-assigned this Oct 30, 2021
@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Oct 30, 2021
@AlexanderSehr AlexanderSehr added this to the Public Preview milestone Oct 30, 2021
@AlexanderSehr AlexanderSehr linked an issue Oct 30, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 31, 2021

Unit Test Results

  1 files  ±0    1 suites  ±0   15s ⏱️ -18s
31 tests +1  31 ✔️ +1  0 💤 ±0  0 ±0 
37 runs  +7  31 ✔️ +1  6 💤 +6  0 ±0 

Results for commit d116774. ± Comparison against base commit d6a613d.

This pull request removes 30 and adds 31 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Parameter files should not contain subscriptionId original value and but a token string
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Management/managementGroups] Template schema should use HTTPS reference
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] Parameter files should not contain subscriptionId original value and but a token string
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as draft October 31, 2021 13:38
@AlexanderSehr AlexanderSehr changed the title Users/alsehr/sql server restructured Sql server restructured Nov 1, 2021
@AlexanderSehr AlexanderSehr changed the base branch from main to dev November 2, 2021 23:01
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 2, 2021 23:02
@MariusStorhaug MariusStorhaug self-requested a review November 3, 2021 08:18
@MariusStorhaug
Copy link
Contributor

Are we removing .github/workflows/ms.sql.servers.databases.yml since we only want to test on the top level resource?

rahalan
rahalan previously approved these changes Nov 3, 2021
MariusStorhaug
MariusStorhaug previously approved these changes Nov 3, 2021
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a new PR to align name for RBAC for all modules, besides that, all ok

@AlexanderSehr AlexanderSehr dismissed stale reviews from MariusStorhaug and rahalan via d116774 November 3, 2021 12:35
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Approved

@AlexanderSehr AlexanderSehr merged commit f6bddd9 into dev Nov 3, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/sqlServerRestructured branch November 3, 2021 13:28
AlexanderSehr added a commit that referenced this pull request Nov 3, 2021
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
AlexanderSehr added a commit that referenced this pull request Nov 6, 2021
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* Update to latest

* Update to latest

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Bugfix

* Bugfix

* Fix param

* Update to latest

* Moved functions to shared utlities folder; fixed remaining issues

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Changed RBAC ID to avoid conflict in resource (MSI does not work)

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SQL Server to new child-resource structure
3 participants