Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Key vault restructured #345

Merged
merged 11 commits into from
Nov 3, 2021
Merged

Key vault restructured #345

merged 11 commits into from
Nov 3, 2021

Conversation

AlexanderSehr
Copy link
Contributor

Change

  • Restructured Key Vault to child-resource structure
  • Updated ReadMe Generation Skript to better work with object references

Pipeline reference:
KeyVault: Vaults

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Nov 1, 2021
@AlexanderSehr AlexanderSehr added this to the Public Preview milestone Nov 1, 2021
@AlexanderSehr AlexanderSehr self-assigned this Nov 1, 2021
@AlexanderSehr AlexanderSehr linked an issue Nov 1, 2021 that may be closed by this pull request
Update Keyvault to new child-resource structure Feature Request enhancement #344
Closed
@AlexanderSehr AlexanderSehr marked this pull request as draft November 1, 2021 18:13
@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

Unit Test Results

  1 files  1 suites   15s ⏱️
  8 tests 8 ✔️   0 💤 0 ❌
40 runs  8 ✔️ 32 💤 0 ❌

Results for commit 27ab638.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr changed the base branch from main to dev November 2, 2021 23:01
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 2, 2021 23:02
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 3, 2021 12:25
MariusStorhaug
MariusStorhaug approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments have been addressed. Approved.

@AlexanderSehr AlexanderSehr merged commit 230daa0 into dev Nov 3, 2021
@AlexanderSehr AlexanderSehr deleted the users/alsehr/keyVaultRestructured branch November 3, 2021 13:18
AlexanderSehr added a commit that referenced this pull request Nov 3, 2021
@AlexanderSehr
Latest DEV to main (#371)
79fef28 
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
AlexanderSehr added a commit that referenced this pull request Nov 6, 2021
@AlexanderSehr
Restructured EventHub to new child-resources structure (#407)
94004ac 
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* Update to latest

* Update to latest

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Bugfix

* Bugfix

* Fix param

* Update to latest

* Moved functions to shared utlities folder; fixed remaining issues

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Changed RBAC ID to avoid conflict in resource (MSI does not work)

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
enhancement New feature or request
Projects
None yet
Milestone
v 0.3
Development

Successfully merging this pull request may close these issues.

Update Keyvault to new child-resource structure Feature Request enhancement
2 participants
@AlexanderSehr @MariusStorhaug