Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ServiceBus Namespace restructured #321

Merged
merged 17 commits into from
Nov 3, 2021

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 30, 2021

Change

  • Restructured Service Bus Namespace to child-resource structure
  • Updated ReadMe Generation Skript to better work with object references

Pipeline reference:
ServiceBus: Namespaces

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added the enhancement New feature or request label Oct 30, 2021
@AlexanderSehr AlexanderSehr added this to the Public Preview milestone Oct 30, 2021
@AlexanderSehr AlexanderSehr self-assigned this Oct 30, 2021
@AlexanderSehr AlexanderSehr marked this pull request as draft October 30, 2021 21:41
@github-actions
Copy link

github-actions bot commented Oct 31, 2021

Unit Test Results

  1 files  ±  0    1 suites  ±0   35s ⏱️ +21s
13 tests  - 18  13 ✔️  - 18    0 💤 ±  0  0 ±0 
45 runs  +12  13 ✔️  - 18  32 💤 +30  0 ±0 

Results for commit e32aecf. ± Comparison against base commit d6a613d.

This pull request removes 31 and adds 13 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] All resources that have a Location property should refer to the Location parameter 'parameters('Location')'
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] If delete lock is implemented, the template should have a lock parameter with the default value of [NotSpecified]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Output names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Parameter files should not contain subscriptionId original value and but a token string
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Parameter names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Insights/components] Standard outputs should be provided (e.g. resourceName, resourceId, resouceGroupName)
…
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2017-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [locks] should use on of the recent API version(s). Currently using [2016-09-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/AuthorizationRules] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/disasterRecoveryConfigs] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/ipfilterrules] should use on of the recent API version(s). Currently using [2018-01-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/migrationConfigurations] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/queues/authorizationRules] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/queues] should use on of the recent API version(s). Currently using [2021-06-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces/virtualnetworkrules] should use on of the recent API version(s). Currently using [2018-01-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ Api version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ServiceBus/namespaces] used resource type [namespaces] should use on of the recent API version(s). Currently using [2021-06-01-preview]
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr changed the title Users/alsehr/namespace restructured ServiceBus Namespace restructured Nov 1, 2021
@AlexanderSehr AlexanderSehr changed the base branch from main to dev November 2, 2021 23:01
@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 2, 2021 23:02
rahalan
rahalan previously approved these changes Nov 3, 2021
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some undeclared changes going on here, i.e cleanup naming of multiple resources in readme's ?
sxx-az-subnet-weu-x-001 -> sxx-az-subnet-x-001 ?

Over all changes:

  • Remove ./
  • Add description to outputs
  • Some stuff I have never seen on defaults on parameters
  • Default value generated by readme script when there is a formula resulting in some crazy stuff in readme.

Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments resolved. Approved

@AlexanderSehr AlexanderSehr merged commit 6ae165d into dev Nov 3, 2021
@MariusStorhaug MariusStorhaug deleted the users/alsehr/namespaceRestructured branch November 3, 2021 19:53
AlexanderSehr added a commit that referenced this pull request Nov 3, 2021
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
AlexanderSehr added a commit that referenced this pull request Nov 6, 2021
* Key vault restructured (#345)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated test

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Sql server restructured (#317)

* Update to latest

* Removed child-resource workflow

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Push updated Readme file(s)

* Update to latest

* Update to latest

* ServiceBus Namespace restructured (#321)

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Updated sku to premium to work with virtual network rules

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Bugfix

* Bugfix

* Fix param

* Update to latest

* Moved functions to shared utlities folder; fixed remaining issues

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Update to latest

* Changed RBAC ID to avoid conflict in resource (MSI does not work)

Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ServiceBus Namespace to new child-resource structureFeature Request
3 participants