-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ServiceBus Namespace restructured #321
Conversation
Unit Test Results 1 files ± 0 1 suites ±0 35s ⏱️ +21s Results for commit e32aecf. ± Comparison against base commit d6a613d. This pull request removes 31 and adds 13 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some undeclared changes going on here, i.e cleanup naming of multiple resources in readme's ?
sxx-az-subnet-weu-x-001 -> sxx-az-subnet-x-001 ?
Over all changes:
- Remove
./
- Add description to outputs
- Some stuff I have never seen on defaults on parameters
- Default value generated by readme script when there is a formula resulting in some crazy stuff in readme.
arm/Microsoft.ServiceBus/namespaces/authorizationRules/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.ServiceBus/namespaces/disasterRecoveryConfigs/deploy.bicep
Outdated
Show resolved
Hide resolved
arm/Microsoft.ServiceBus/namespaces/migrationConfigurations/deploy.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments resolved. Approved
* Key vault restructured (#345) * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Updated test * Update to latest * Update to latest * Update to latest * Update to latest * Sql server restructured (#317) * Update to latest * Removed child-resource workflow * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Push updated Readme file(s) * ServiceBus Namespace restructured (#321) * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Updated sku to premium to work with virtual network rules * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
* Key vault restructured (#345) * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Updated test * Update to latest * Update to latest * Update to latest * Update to latest * Sql server restructured (#317) * Update to latest * Removed child-resource workflow * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Push updated Readme file(s) * Update to latest * Update to latest * ServiceBus Namespace restructured (#321) * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Updated sku to premium to work with virtual network rules * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Bugfix * Bugfix * Fix param * Update to latest * Moved functions to shared utlities folder; fixed remaining issues * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Update to latest * Changed RBAC ID to avoid conflict in resource (MSI does not work) Co-authored-by: CARMLPipelinePrincipal <CARML@noreply.github.com>
Change
Pipeline reference:

Type of Change
Please delete options that are not relevant.
Checklist