Camera Controller can go underground #5837

ggetz · 2017-09-18T20:43:49Z

Move the camera while terrain is still loading in:

Appeared after #5603

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/50CK4haCIiw

mramato · 2017-09-19T13:53:24Z

Are you sure #5603 caused this? We specifically allow the camera to go underground during load because otherwise flights and abrupt camera changes wouldn't work correctly. See #4105. If this is differently, please explain how.

ggetz · 2017-09-19T15:59:53Z

@mramato If this is intended behavior, I'm fine with closing this.

mramato · 2017-09-19T20:33:52Z

Please feel free to re-open if there is some additional context I'm missing. You might also want to follow up on the forum post. Thanks.

cesium-concierge · 2017-09-19T20:33:53Z

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/50CK4haCIiw

If this issue affects any of these threads, please post a comment like the following:

The issue at #5837 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Thanks again.

wallw-teal · 2017-10-04T22:08:18Z

#5603 absolutely caused a change in behavior.

I commented in #5603 but I'll copy it here:

The additional call to camera.setView() should not affect its position, at least according to how I understand the documentation. However, it most certainly is affecting the position as commenting out that one line fixes the problem (but leaves #4639 unresolved in some cases).

ZacBrownBand · 2018-01-05T19:48:07Z

Any update on this issue?

ggetz · 2018-01-08T14:45:08Z

@ZacBrownBand, no additional updates. If you could contribute a fix, or continue to narrow down what the problem is, it would help move things along and we would greatly appreciate it!

gberaudo · 2018-01-09T10:42:21Z

@ZacBrownBand, I created #6012 which also fixes this.

ggetz · 2018-01-31T21:57:03Z

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/cPbtbShkSOQ

ggetz · 2018-05-04T13:47:55Z

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/Sn5R5FzOr1k

ggetz · 2018-05-08T14:18:01Z

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/TDMwlbT0xBE

hpinkos · 2018-05-10T15:37:27Z

Also reported by @fgamezc in #6581

hpinkos · 2018-05-24T19:01:41Z

Also reported by @safa833 in #6623

hpinkos · 2018-07-31T14:59:11Z

Also reported by @miniergouzi in #6856

OmarShehata · 2018-09-18T15:02:36Z

Reported in this forum thread with a video and how to recreate.

lilleyse · 2018-09-24T15:47:10Z

Came up again in the context of navigating around a point cloud and ending up underground accidentally. I'm curious if anyone knows of any workarounds for this.

mramato · 2018-09-24T16:03:37Z

@lilleyse the problem is pretty nuanced, You can modify the end of Camera.update to always set _suspendTerrainAdjustment to false and always call _adjustHeightForTerrain and that would prevent the camera from ever going under terrain, however functions like zoomTo/FlyTo will not work as expected near the ground because they will "bump into" lower res terrain and end up at a higher altitude than desired.

mramato · 2018-09-24T16:04:08Z

We also tweaked this behavior in master to be better, so I would try that out if you aren't already.

lilleyse · 2018-09-24T19:19:31Z

Yeah I can see some of the tradeoffs.

That workaround is good for the case I'm describing. It would be nice if the camera could apply terrain adjustment if being acted upon by the user but otherwise not. The details may be more complicated than that though.

bmr74 · 2018-11-07T19:12:58Z

I think the adjustment for terrain would be better if it were invoked by the ScreenSpaceCameraController instead of the camera itself. When programmatically controlling the camera, you don't want the camera doing things you didn't tell it explicitly to do. So the responsibility is ill-placed, it should be with the user control of the camera.

Meanwhile this can fixed like so:

var viewer = new Cesium.Viewer('cesiumContainer');

viewer.camera.changed.addEventListener(
function() {
if (viewer.camera._suspendTerrainAdjustment && viewer.scene.mode === Cesium.SceneMode.SCENE3D) {
viewer.camera._suspendTerrainAdjustment = false;
viewer.camera._adjustHeightForTerrain();
}
}
);

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=jVFdS8MwFP0roQ9bC3KL+Lh2KHXiw9SHiU8FuUtut2iajHx0TPG/m64bbArieUnuyfm4kA4t6yRtybKSadqyipwMLbzsuXTM92NltEepyY6zSa1rPTiAY0sWga9Rr0gACjHrSPu5dJ6iOK01i2iC5l4anWbsc2B6yIal5zGvLrgNafFM1sayG/EWnG9jHhuNDjuC4zEYWiOIlWV5XHbRsw+RhEU1e5xd3Z419fhvU8kaVI4mf7pxr78nuVr7O2MPKWl24voarvHIJslFUji/UzQdyGvZboz1LFiVAuSe2o1CTy5fBv5OHrhzfVSRH02FkB2ToqyTH79RJ4wrdC6+NEGphfygOpkWedSf2ZRBIfXqqSOrcNdL1pfT+UACQJHH8bfLG6OWaE8SvwE

miniergouzi · 2018-11-14T03:03:59Z

@bmr74

This problem occurs when the mouse pulley is indented.

bmr74 · 2018-11-14T14:05:57Z

@miniergouzi my fix should help, but is not a complete solution. You can still go under the terrain, it just recovers much faster. One thing I did was to also limit the pitch, which is fine for my particular application. You could also add a min zoom distance, if that is acceptable in your application.

I can't see the full stack trace and I have not seen that problem. What browser/version are you using? Can you provide the complete stack trace?

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=rVRdb5swFP0rVh5akDqTrW8Fok1Zpk1rl6qJuhekyIFL8GZsZBu6fuS/zwYSAmmrappfMJdzju8995qKSFRRuAOJQsThDk1B0TLHt3XMOY3r16ngmlAO8tT1Ix7xyrByyq+pjjPDe9eSrojO8PW31fx2drNa/pz7LZL82SHH/p78Fegm0yb2YTxuROsjcUxykATHGeEbSDBJklkFXF9SpcFk4EQcmZWWPNZUcMdFj03ELpoipy+zUqUqgCdLkNJU8Cn5VSqdGz10ctIWjlVshHEuEkBhGO4cWNjolQnixXT2Y3b+uXeSXW89KUQpYQr8V9mkxjemfBGyVXHcA9a223Y7z0PfAQrU6CDKEUESiBKcrBmgojZeWi87ju1A0Xakn0YdrbtxaGmDnXSNfHpq+cF+DF5ypzFXxRKALwoSw7Q+yU6UFIwZBNSZLik7dKqvZYqMGckLpLO2pP53mh7naBJCfZRdu7J3MH+A2SIwCXSCrxTYk2tBgx5vh4VY5xNQmnJipxftp21KpDY7ws9xKkV+QxKzV87xiYN+CUWtkKWLjSRFRmPMBN9QXSZw9m90k9oL7PqCG+ucN8hk9SifdVfddY/62pdRoO1vx3nG5wPPLg5fnslRSGouXQt9bDp00TZqO2iP6/+PmdWyhONrah6uPzobBUrfM5g0wY80L4TUqJTMwdjTkBfGblDeuox/g8axUjanwNuRgoRWiCZhNBr8iaORvRJKmS9pydiCPkA0mgSewfdoTJhR4pt5BZKRewvJ3k8umyDGOPDM6zFLC8HWRB4o/gU

ohadmanor · 2018-11-15T13:33:57Z

viewer.camera.changed.addEventListener(
function() {
if (viewer.camera._suspendTerrainAdjustment && viewer.scene.mode === Cesium.SceneMode.SCENE3D) {
viewer.camera._suspendTerrainAdjustment = false;
viewer.camera._adjustHeightForTerrain();
}
}
);

That's work great! it fix the problem.

bbehling-trimble · 2019-03-18T19:09:06Z

I'm still able to get the camera to go under the terrain in Cesium v1.55. Is the fix mentioned by @bmr74 going to be permanent? Seems incorrect to use 'private' class members.

bbehling-trimble · 2019-03-18T19:09:45Z

Also see this error occur using @bmr74 workaround

seems to only happen when

if (viewer.camera._suspendTerrainAdjustment && viewer.scene.mode === Cesium.SceneMode.SCENE3D)

is added

popoleeMaster · 2019-05-10T02:06:15Z

I still have this problem with the latest version. In the default exemple, just press the center button on a mouse, drag the mouse around, and release, you will have such a wierd view that was not at all what is intended to be.

engineerhe · 2019-07-03T08:33:11Z

@bmr74 your answer does work，Strong!

cesium-concierge · 2020-01-06T19:48:50Z

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/50CK4haCIiw
https://groups.google.com/forum/#!topic/cesium-dev/cPbtbShkSOQ
https://groups.google.com/forum/#!topic/cesium-dev/Sn5R5FzOr1k
https://groups.google.com/forum/#!topic/cesium-dev/TDMwlbT0xBE
https://groups.google.com/d/msg/cesium-dev/Mq4i8gC6eAE/-jeRGSn6CAAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #5837 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

ggetz mentioned this issue Sep 18, 2017

Maintain camera heading, pitch, and roll on zoom #5603

Merged

mramato closed this as completed Sep 19, 2017

emackey reopened this Oct 5, 2017

ggetz mentioned this issue Oct 9, 2017

Camera sinks under terrain #5888

Closed

hpinkos added category - camera type - bug labels Oct 17, 2017

gberaudo mentioned this issue Jan 9, 2018

Allow applications to control terrain adjustment suspension #6012

Closed

ggetz mentioned this issue Feb 5, 2018

when tilt camera slanted into the ground #6181

Closed

hpinkos mentioned this issue May 10, 2018

Camera below the terrain surface #6581

Closed

hpinkos mentioned this issue May 24, 2018

How to avoid passing underneath globe #6623

Closed

hpinkos mentioned this issue Jul 31, 2018

The problem of escaping from the angle of view #6856

Closed

OmarShehata mentioned this issue May 20, 2019

The camera rotates below the ground #7741

Closed

OmarShehata mentioned this issue Sep 30, 2019

Camera crashes when flying underground #8226

Closed

OmarShehata mentioned this issue Nov 22, 2019

prevent the camera from going underground #8412

Closed

lilleyse mentioned this issue Jan 2, 2020

Prevent camera from going underground during mouse navigation #8504

Merged

IanLilleyT closed this as completed in #8504 Jan 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Camera Controller can go underground #5837

Camera Controller can go underground #5837

ggetz commented Sep 18, 2017

mramato commented Sep 19, 2017

ggetz commented Sep 19, 2017

mramato commented Sep 19, 2017

cesium-concierge commented Sep 19, 2017

wallw-teal commented Oct 4, 2017

ZacBrownBand commented Jan 5, 2018

ggetz commented Jan 8, 2018

gberaudo commented Jan 9, 2018

ggetz commented Jan 31, 2018

ggetz commented May 4, 2018

ggetz commented May 8, 2018

hpinkos commented May 10, 2018

hpinkos commented May 24, 2018

hpinkos commented Jul 31, 2018

OmarShehata commented Sep 18, 2018

lilleyse commented Sep 24, 2018

mramato commented Sep 24, 2018

mramato commented Sep 24, 2018

lilleyse commented Sep 24, 2018

bmr74 commented Nov 7, 2018

miniergouzi commented Nov 14, 2018

bmr74 commented Nov 14, 2018 •

edited

Loading

ohadmanor commented Nov 15, 2018

bbehling-trimble commented Mar 18, 2019

bbehling-trimble commented Mar 18, 2019 •

edited

Loading

popoleeMaster commented May 10, 2019

engineerhe commented Jul 3, 2019

cesium-concierge commented Jan 6, 2020

Camera Controller can go underground #5837

Camera Controller can go underground #5837

Comments

ggetz commented Sep 18, 2017

mramato commented Sep 19, 2017

ggetz commented Sep 19, 2017

mramato commented Sep 19, 2017

cesium-concierge commented Sep 19, 2017

wallw-teal commented Oct 4, 2017

ZacBrownBand commented Jan 5, 2018

ggetz commented Jan 8, 2018

gberaudo commented Jan 9, 2018

ggetz commented Jan 31, 2018

ggetz commented May 4, 2018

ggetz commented May 8, 2018

hpinkos commented May 10, 2018

hpinkos commented May 24, 2018

hpinkos commented Jul 31, 2018

OmarShehata commented Sep 18, 2018

lilleyse commented Sep 24, 2018

mramato commented Sep 24, 2018

mramato commented Sep 24, 2018

lilleyse commented Sep 24, 2018

bmr74 commented Nov 7, 2018

miniergouzi commented Nov 14, 2018

bmr74 commented Nov 14, 2018 • edited Loading

ohadmanor commented Nov 15, 2018

bbehling-trimble commented Mar 18, 2019

bbehling-trimble commented Mar 18, 2019 • edited Loading

popoleeMaster commented May 10, 2019

engineerhe commented Jul 3, 2019

cesium-concierge commented Jan 6, 2020

bmr74 commented Nov 14, 2018 •

edited

Loading

bbehling-trimble commented Mar 18, 2019 •

edited

Loading