-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Loop tidepool-merge with improvements from dev #2312
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
marionbarker
wants to merge
13
commits into
tidepool-merge
Choose a base branch
from
update_tidepool-merge
base: tidepool-merge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust provisioning profile path in script for Xcode 16 compatibility
update progressCell for bolus display
Force reload from UserDefaults for Algorithm Experiments
* Configure the version number in LoopWorkspace, not Loop * enable VersionOveride to be placed in LoopWorkspace * report the LoopWorkspace branch in Settings * reorder search for version override, add note about version for DIY Loop
…2163) The 'predicted' dataset on the 'glucose change' graph was calculated using insulin counteraction effects that had been truncated to the width of the chart. This meant that carb entries early in the timeline may not have dynamic carb absorption applied as the implied ICE was zero for the first part of the carb entry's history.
Signed-off-by: Jörg Schömer <joerg@joerg-schoemer.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bring in improvements added to the dev branch since the tidepool-merge branch was first pushed to LoopKit
Test
Start with a local clone using LoopWorkspace
tidepool-merge
branch:Loop/View Controllers/CarbAbsorptionViewController.swift
Loop/View Controllers/StatusTableViewController.swift
Confirm operation is nominal.