npm - add validator, dependency of angular.validators

[himdel]

angular.validators is special:
when loaded in the context of the browser, it bundles its own copy of the validator library
when loaded via require, it expects a global validator object and uses that

=> adding an explicit validator dependency and making sure the object exists

this also allows us to use a more recent version of validator

Fixes #4660 (introduced in #4622)

@djberg96 can you confirm this fixes the issue for you please? :)

[miq-bot]

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/5697d51557d75c2388efda19b6bdfb2d4b54553e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

[mzazrivec]

Even with this change in place and bin/update I see the following in javascript console:

TypeError: validator.isUUID is not a function
    at controller.$validators.isUuid (angular.validators.js:1533)
    at angular.js:29186
    at forEach (angular.js:422)
    at processSyncValidators (angular.js:29185)
    at Object.$$runValidators (angular.js:29157)
    at Object.$$parseAndValidate (angular.js:29302)
    at Object.$commitViewValue (angular.js:29268)
    at angular.js:29409
    at ChildScope.$eval (angular.js:18542)
    at ChildScope.$apply (angular.js:18641)
(anonymous) @ angular.js:14800
(anonymous) @ angular.js:11218
$apply @ angular.js:18646
$$debounceViewValueCommit @ angular.js:29408
$setViewValue @ angular.js:29386
listener @ angular.js:25260
dispatch @ jquery.js:4737
elemData.handle @ jquery.js:4549

[himdel]

Oops, aah, I misread .. validator is not taken from the global context there, it's injected nodeValidator... and

angular.element('.ng-scope').injector().get('nodeValidator')
> {}

(no methods)

(created gkaimakas/angular.validators#3)

[himdel]

Closed in favor of #4667