angular.validators - work around nodeValidator=={} #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular.validators only works correctly when loaded in a browser-like environment if module, exports or define are defined, the nodeValidator service ends up becoming an empty object and an attempt at exporting what would have been the service is made this is to ensure that no such vars are defined for angular.validators
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/dee7d9d8ae82ef87ac504b99c55a6ce51c27b1dd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
We can use this, or we can wait for gkaimakas/angular.validators#4 + a npm release. |
|
Update.. the PRs are merged .. so maybe.. (watching https://www.npmjs.com/package/angular.validators :)) |
|
@himdel @AparnaKarve This worked, thanks! |
|
#4670 removes the workaround, as it's no longer needed with the new version |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
angular.validators only works correctly when loaded in a browser-like environment - gkaimakas/angular.validators#3
if
module,exportsordefineare defined, thenodeValidatorservice ends up becoming an empty object and an attempt at exporting what would have been the service is madethis is to ensure that no such vars are defined for
angular.validatorsFixes #4660 (introduced in #4622)
@djberg96 can you confirm this fixes the issue for you please? :)