angular.validators - update and remove imports-loader workaround #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing: #4660 is still fixed :)
|
we had a workaround for loading angular.validators in a browser-like context to prevent the validator service becoming empty this is needed when using angular.validators < 4.4.3 with webpack but 4.4.3 just got released, removing the workaround
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/cc5283aad47597dd73c19ff23b366ffd2dea9671 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a workaround (#4667) for loading angular.validators in a browser-like context to prevent the validator service becoming empty (#4660)
this is needed when using angular.validators < 4.4.3 with webpack
but 4.4.3 just got released (gkaimakas/angular.validators#7), removing the workaround
4.4.3 contains the following changes from 4.4.2:
require('angular.validators')(added index.js)This essentially reverts #4667, but it does not remove
imports-loaderbeause it is needed for #4641 (comment)