Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

publish validated airspeed topic #24302

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

bdilman
Copy link
Contributor

@bdilman bdilman commented Feb 6, 2025

Solved Problem

This PR adds the AirspeeValidated msg under published dds topics in dds_topics.yaml. ROS2 applications with fixed-wing vehicles can with this change receive airspeed information.

To-do:

  • attach simulation test
  • compare Tx rates before/after this change
  • edit PR description

Fixes #{Github issue ID}

Solution

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

We could also ...

Test coverage

Context

Related links, screenshot before/after, video

@bdilman bdilman requested a review from sfuhrer February 6, 2025 17:32
Copy link

github-actions bot commented Feb 6, 2025

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 304 byte (0.01 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +304  +0.0%    +304    .text
  +0.6%    +220  +0.6%    +220    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.0%     +77  +0.0%     +77    [section .text]
  +0.1%      +4  +0.1%      +4    ../../src/modules/vtol_att_control/vtol_type.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +40  [ = ]       0    .debug_frame
+0.0%    +335  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.3%    +339  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%    +505  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +1.0%    +530  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%    +194  [ = ]       0    .debug_loc
  +0.6%    +194  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%     +34  [ = ]       0    .debug_str
  +0.2%     +34  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%     +56  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +1.6%     +56  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.0%     +32  [ = ]       0    [section .strtab]
+0.0%     +32  [ = ]       0    .symtab
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +1.1%     +32  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.1%     +48  [ = ]       0    [section .symtab]
-2.5%    -304  [ = ]       0    [Unmapped]
+0.0% +1.22Ki  +0.0%    +304    TOTAL

px4_fmu-v6x [Total VM Diff: 304 byte (0.02 %)]
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +304  +0.0%    +304    .text
  +0.6%    +220  +0.6%    +220    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.0%     +77  +0.0%     +77    [section .text]
  +0.1%      +4  +0.1%      +4    ../../src/modules/vtol_att_control/vtol_type.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
+0.0%     +40  [ = ]       0    .debug_frame
+0.0%    +335  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.3%    +339  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%    +505  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +1.0%    +530  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%    +194  [ = ]       0    .debug_loc
  +0.6%    +194  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%     +34  [ = ]       0    .debug_str
  +0.2%     +34  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
+0.0%     +56  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
  +1.6%     +56  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.0%     +32  [ = ]       0    [section .strtab]
+0.0%     +32  [ = ]       0    .symtab
  -7.0%     -64  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +16  [ = ]       0    ../../src/modules/fw_pos_control/FixedwingPositionControl.cpp
  +1.1%     +32  [ = ]       0    ../../src/modules/uxrce_dds_client/uxrce_dds_client.cpp
  +0.1%     +48  [ = ]       0    [section .symtab]
-0.4%    -304  [ = ]       0    [Unmapped]
+0.0% +1.22Ki  +0.0%    +304    TOTAL

Updated: 2025-02-07T13:13:43

Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing the airspeed measurement is crucial for fixed-wing ROS applications.

@beniaminopozzan do you agree?

Copy link
Member

@beniaminopozzan beniaminopozzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfuhrer 100%

@bdilman bdilman marked this pull request as ready for review February 7, 2025 12:13
@bdilman bdilman force-pushed the publish-validated-airspeed-topic branch from 973e418 to ae5d7b6 Compare February 7, 2025 13:08
@bdilman bdilman merged commit ce64263 into main Feb 7, 2025
61 checks passed
@bdilman bdilman deleted the publish-validated-airspeed-topic branch February 7, 2025 13:44
@sfuhrer
Copy link
Contributor

sfuhrer commented Feb 7, 2025

We need to add AirspeedValidated.msg to the versioned topics after this change.

JoelJ18 pushed a commit to microstrain-robotics/PX4-Autopilot that referenced this pull request Feb 24, 2025
* publish validated airspeed topic

* fix typo
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants