Allow setting mutex locking/unlocking callbacks before trace init. #46
Conversation
Calling mbed_trace_init() set the callbacks to NULL so they had to be set after initializing the library. This left a small window of time during which traces could happen without any thread safety being in place.
|
@RomanSaveljev @kjbracey-arm Could you review please. |
| @@ -162,9 +162,6 @@ int mbed_trace_init(void) | |||
| m_trace.suffix_f = 0; | |||
| m_trace.printf = mbed_trace_default_print; | |||
| m_trace.cmd_printf = 0; | |||
| m_trace.mutex_wait_f = 0; | |||
| m_trace.mutex_release_f = 0; | |||
| m_trace.mutex_lock_count = 0; | |||
There was a problem hiding this comment.
Ok, does not belong to this PR, but I would use here something like "NULL-object" pattern to avoid if (m_trace.mutex_wait_f) {...} everywhere
There was a problem hiding this comment.
Yep, that would be a good idea, but for another PR indeed.
|
Do we need a mutex for |
|
Currently the mutexes are only meant to protect the actual trace calls. Initialization and configuration aren't protected. |
|
Needs to be documented carefully, because of the "creativity window" we leave open for the user. LGTM |
|
I'll add a little more documentation. |
|
@SeppoTakalo Could you take a look at this please. |
|
+1 |
* origin/master: (22 commits) output/ added to gitignore list (#66) Added include_directories(${CMAKE_CURRENT_SOURCE_DIR}/) include to resolve compilation error for Linux. (#63) Ensure tr_array doesn't print <null> when len == 0 (#65) Add CMakeLists.txt to support PAL Tools (#61) Fix header documentation (#58) Update README.md (#57) Provide environment-agnostic configuration macros. (#54) Flash size can be limited by defining MBED_TRACE_MAX_LEVEL Use temp variable in mutex release loop (#52) Fix race condition when unlocking mutex Add instructions for enabling the library in mbed OS 5. (#50) document update. (#47) Allow setting mutex locking/unlocking callbacks before trace init. (#46) Ipv6 helpers update (#44) Fix disabling traces through the YOTTA_CFG_MBED_TRACE flag. (#45) Deprecate the misnamed YOTTA_CFG_MTRACE_TMP_LINE_LENGTH flag, which is to be removed in the next release. (#43) Changed dummy definitions to match the actual functions' return types (#40) FEA_TRACE_SUPPORT flag is always set when traces are enabled. (#39) Release merge to master (#38) Add nanostack-libservice lib to CMakeLists (#31) ...
Calling mbed_trace_init() set the callbacks to NULL so they had to be set after initializing the library.
This left a small window of time during which traces could happen without any thread safety being in place.