Add CMakeLists.txt to support PAL Tools #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is cleaned up version of the other PR. This should be enough. |
|
Added yotta_ignore for backwards compatibility |
netanelgonen
approved these changes
Feb 14, 2017
|
I don't have experience with cmake either, but this is sliiightly failing to build at the moment. |
|
Fixed the syntax in .yotta_ignore |
tommikas
suggested changes
Feb 16, 2017
CMakeLists.txt
Outdated
| FILE(GLOB MBED_TRACE_SRC | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/source/*.c" | ||
|
|
||
| ) |
There was a problem hiding this comment.
Couldn't the above 4 lines be just one line?
CMakeLists.txt
Outdated
| project(mbedTrace) | ||
|
|
||
|
|
||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include/) |
There was a problem hiding this comment.
Is this correct? There's no include directory here, the header is in mbed-trace.
CMakeLists.txt
Outdated
|
|
||
|
|
||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include/) | ||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/) |
There was a problem hiding this comment.
Does cmake need this? There's no source files directly in the root directory.
tommikas
approved these changes
Feb 16, 2017
jupe
reviewed
Mar 6, 2017
|
|
||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/mbed-trace/) | ||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../nanostack-libservice/mbed-client-libservice/) | ||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../nanostack-libservice/) |
There was a problem hiding this comment.
why two includes from libservice?
tommikas
pushed a commit
that referenced
this pull request
Jun 16, 2017
* origin/master: (22 commits) output/ added to gitignore list (#66) Added include_directories(${CMAKE_CURRENT_SOURCE_DIR}/) include to resolve compilation error for Linux. (#63) Ensure tr_array doesn't print <null> when len == 0 (#65) Add CMakeLists.txt to support PAL Tools (#61) Fix header documentation (#58) Update README.md (#57) Provide environment-agnostic configuration macros. (#54) Flash size can be limited by defining MBED_TRACE_MAX_LEVEL Use temp variable in mutex release loop (#52) Fix race condition when unlocking mutex Add instructions for enabling the library in mbed OS 5. (#50) document update. (#47) Allow setting mutex locking/unlocking callbacks before trace init. (#46) Ipv6 helpers update (#44) Fix disabling traces through the YOTTA_CFG_MBED_TRACE flag. (#45) Deprecate the misnamed YOTTA_CFG_MTRACE_TMP_LINE_LENGTH flag, which is to be removed in the next release. (#43) Changed dummy definitions to match the actual functions' return types (#40) FEA_TRACE_SUPPORT flag is always set when traces are enabled. (#39) Release merge to master (#38) Add nanostack-libservice lib to CMakeLists (#31) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.