Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

79 card #241

Merged
merged 49 commits into from
Nov 1, 2018
Merged

79 card #241

merged 49 commits into from
Nov 1, 2018

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Oct 30, 2018

READY FOR REVIEW

Summary

  • Creates Vertical Card Component
  • Creates Horizontal Card Variant
  • Adds start to modular spacing mixins
  • Adds start to box shadows
  • Makes improvements to button component
  • Removes and updates input.html to input.twig
  • Has some dependencies on typography mixins
  • Will need to refactor modular and shadow mixins

Needed By (Date)

  • End of the week?

Urgency

  • Medium-low

Steps to Test

  1. Read through the code and leave comments to approach
  2. Check out this branch locally
  3. Compile style guide
  4. Review Card component in browser for look and feel
  5. Review Card component in browser for accessibility and semantics
  6. Review Card component in browser for responsiveness

Associated Issues and/or People

See Also

@sherakama sherakama self-assigned this Oct 30, 2018
@sherakama
Copy link
Member Author

@JBCSU @josephgknox

Ready for the second review.

Copy link

@josephgknox josephgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much goodness here! Looks great. Left minor margin mixin suggestions.

Joe Knox and others added 9 commits November 1, 2018 13:13
Co-Authored-By: sherakama <sherakama@gmail.com>
Co-Authored-By: sherakama <sherakama@gmail.com>
Co-Authored-By: sherakama <sherakama@gmail.com>
Co-Authored-By: sherakama <sherakama@gmail.com>
Co-Authored-By: sherakama <sherakama@gmail.com>
* master:
  make color change on hover & focus less abrupt (#253)
@JBCSU JBCSU merged commit fa1cce4 into master Nov 1, 2018
@JBCSU JBCSU deleted the 79-card branch November 1, 2018 20:37
JBCSU added a commit that referenced this pull request Nov 1, 2018
* master:
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
  249: Change CTA icon to a variable (#251)
  223 brand bar (#243)
  Color swatches. (#244)

# Conflicts:
#	core/scss/utilities/functions/index.scss - manually resolved
yvonnetangsu added a commit that referenced this pull request Nov 2, 2018
* master:
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
  px to rem (#256)
  219 Modular typography (#250)
  fixup! wip. (#255)
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
yvonnetangsu added a commit that referenced this pull request Nov 7, 2018
* master:
  216 Create site search component (#262)
  266: Update scss file to reference logo.twig and update twig file to … (#267)
  246 homepage (#258)
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
  px to rem (#256)
  219 Modular typography (#250)
  fixup! wip. (#255)
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
  249: Change CTA icon to a variable (#251)
  223 brand bar (#243)

# Conflicts:
#	core/css/decanter.css
#	core/scss/components/index.scss
#	core/templates/components/logo/logo.twig
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants