Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change class for logo. #257

Merged
merged 3 commits into from
Nov 2, 2018
Merged

change class for logo. #257

merged 3 commits into from
Nov 2, 2018

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Nov 1, 2018

READY FOR REVIEW

Summary

  • Changes logo class to su-logo

Needed By (Date)

  • ?

Urgency

  • Low

Steps to Test

  1. Review code
  2. compile styleguide
  3. Review logo in browser

See Also

@sherakama sherakama self-assigned this Nov 1, 2018
Copy link

@josephgknox josephgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JBCSU JBCSU merged commit 27b8b62 into master Nov 2, 2018
@JBCSU JBCSU deleted the su-logo branch November 2, 2018 16:54
JBCSU added a commit that referenced this pull request Nov 2, 2018
* master:
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)

# Conflicts:
#	core/css/decanter.css - regenerated using mine
#	core/scss/utilities/mixins/typography/_font-lead.scss - resolved using mine
#	core/scss/utilities/mixins/typography/_h6.scss - deleted
yvonnetangsu added a commit that referenced this pull request Nov 2, 2018
* master:
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
yvonnetangsu added a commit that referenced this pull request Nov 2, 2018
* master:
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
  px to rem (#256)
  219 Modular typography (#250)
  fixup! wip. (#255)
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
yvonnetangsu added a commit that referenced this pull request Nov 7, 2018
* master:
  216 Create site search component (#262)
  266: Update scss file to reference logo.twig and update twig file to … (#267)
  246 homepage (#258)
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
  px to rem (#256)
  219 Modular typography (#250)
  fixup! wip. (#255)
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
  249: Change CTA icon to a variable (#251)
  223 brand bar (#243)

# Conflicts:
#	core/css/decanter.css
#	core/scss/components/index.scss
#	core/templates/components/logo/logo.twig
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants