Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

249: Change CTA icon to a variable #251

Merged
merged 2 commits into from
Nov 1, 2018
Merged

249: Change CTA icon to a variable #251

merged 2 commits into from
Nov 1, 2018

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Nov 1, 2018 •
edited
Loading

READY FOR REVIEW

Summary

  • Changed the icon to a variable (icon_src) since FontAwesome integration isn't ready; also pulled some CSS styles of components out of parent class wrapper in the mixin file.

Needed By (Date)

  • End of week

Steps to Test

  1. Pull this branch
  2. Run grunt styleguide and check that the 3 CTA variants are there and the icon one is rendering a svg icon from the img directory.
  3. Check that the cta.twig file is set up correctly

Affected Projects or Products

  • Decanter

Associated Issues and/or People

@yvonnetangsu
249: Change icon to a variable (icon_src) due to fontawesome still be…
5f48301 
…ing investigated; pull CSS for components out of parent wrapper in default mixin file
@yvonnetangsu yvonnetangsu self-assigned this Nov 1, 2018
@sherakama sherakama merged commit 88cfe6e into master Nov 1, 2018
@sherakama sherakama deleted the 249-CTA-icon branch November 1, 2018 17:45
JBCSU added a commit that referenced this pull request Nov 1, 2018
@JBCSU
Merge branch 'master' into 217-levers
14f5a57 
* master:
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
  249: Change CTA icon to a variable (#251)
  223 brand bar (#243)
  Color swatches. (#244)

# Conflicts:
#	core/scss/utilities/functions/index.scss - manually resolved
yvonnetangsu added a commit that referenced this pull request Nov 7, 2018
@yvonnetangsu
Merge branch 'master' into 215-lockup
1586d3a 
* master:
  216 Create site search component (#262)
  266: Update scss file to reference logo.twig and update twig file to … (#267)
  246 homepage (#258)
  reversed order of modular scale type mixin (#260)
  122 hero (#259)
  195 added all Stanford approved fonts (#248)
  change class for logo to match new naming conventions. (#257)
  px to rem (#256)
  219 Modular typography (#250)
  fixup! wip. (#255)
  79 card (#241)
  make color change on hover & focus less abrupt (#253)
  249: Change CTA icon to a variable (#251)
  223 brand bar (#243)

# Conflicts:
#	core/css/decanter.css
#	core/scss/components/index.scss
#	core/templates/components/logo/logo.twig
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sherakama sherakama sherakama left review comments

@josephgknox josephgknox Awaiting requested review from josephgknox

Assignees

@yvonnetangsu yvonnetangsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama