Opening a non-working-set file doesn't select it in tree if a folder was selected before

[peterflynn]

1. Select a folder in the project tree (not a file)
2. Do a 'find across files'
3. Make sure one of the files in the results list is visible in your project tree (parent folder is expanded), and is not in the working set
4. Click one of the results in that file

(You can also repro this by clicking the header link in inline editors, or by using File > Open)

Result: Folder remains selected in project tree. No selection highlight shown for the file that you just opened.

Expected: Selection highlight moves to the file you just opened.

This is a regression from the #1117 fix (pull #1269).

[peterflynn]

@tvoliter, looks like this comes from the new if (selected && selected.isDirectory) check in ProjectManager. I wonder if we could replace that with a a flag so that we just ignore "documentSelectionFocusChange" events while calling setFileSelectionFocus(). (Since the goal of that call is only to notify WorkingSetView, not the project tree that has already responded to the click).

This isn't that easy to hit, but I preliminarily tagged it Sprint 11 since it's a regression (afaict).

[peterflynn]

Ugh, Github again.... reopening to actually verify it

[peterflynn]

Confirmed fixed