This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Don't call _fireSelectionChanged() twice #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
RaymondLim
added a commit
that referenced
this pull request
Aug 22, 2013
Don't call _fireSelectionChanged() twice
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working set selection was getting painted twice.
_updateListSelection()already calls_fireSelectionChanged(), so don't call it again.This saves ~50ms (of 190ms) on my Windows 7 system.
After removing
_fireSelectionChanged()call from_handleDocumentSelectionChange(), there was nothing left except call to_updateListSelection(), so I removed_handleDocumentSelectionChange()function and just call_updateListSelection()directly.This is for #4757, but there may be more we can do.