This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Correctly handle focus changes between working set and file tree when activating document from find in filesfixes #1280 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler when only the focus has changed
ghost
assigned 
|
reviewing |
| @@ -355,6 +361,8 @@ define(function (require, exports, module) { | |||
| _handleDocumentSelectionChange(); | |||
| _fireSelectionChanged(); | |||
| }); | |||
|
|
|||
| $(FileViewController).on("fileViewFocusChange", _updateListSelection); | |||
There was a problem hiding this comment.
It seems inconsistent that the fileViewFocusChange event calls _updateListSelection() directly, and the documentSelectionFocusChange event calls _handleDocumentSelectionChange() (which simply call _updateListSelection()). I think it would be easier to understand this code if both events called the same function. Can we get rid of the _handleDocumentSelectionChange() function?
There was a problem hiding this comment.
Another option is to move the call to _fireSelectionChanged() into the _handleDocumentSelectionChange() function to make the event binding cleaner,
…andleDocumentSelectionFocusChange
redmunds
added a commit
that referenced
this pull request
Jul 21, 2012
Correctly handle focus changes between working set and file tree when activating document from find in filesfixes #1280
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1280. Send a different type of notification from FileViewController when only the focus has changed so that the working set and file tree redraw without assuming a document change notification