RIP 56 Replace Logging Module with Shaded Logback
- Current State: Proposed
- Authors: aaron-ai
- Shepherds: lizhanhui,zhouxinyu
- Mailing List Discussion: dev@rocketmq.apache.org
- Pull Request: #PR_NUMBER
- Released: <released_version>
- Will we add a new module? -- Remove a module actually.
- Will we add new APIs? No.
- Will we add a new feature? -- Yes.
The existing logging module is unnecessary, and the code quality is a concern.
Remove redundant logging module and keep it always latest with logback.
The existing logging just aims to avoid the confliction between different bindings of SLF4J, but the code quality is a concern and it migrate a lot of code snippets from the previous version of logback/log4j, which may contains vulnerabilities.
Nothing specific.
We intend to shade logback to replace the existing logging module. To avoid the clash of configuration file, the shaded logback will use rmq.logback.xml/rmq-logback-test.xml/rmq-logback.groovy rather than original logback.xml/logback-test.xml/logback.groovy.
Especially, the key of system property and environment is also be shaded to keep the original logback and the shaded logback independent.
An independent repo will be established to release the shaded logback periodically. You can see an example from: https://github.com/aliyun-mq/rocketmq-logging (Not the ultimate version)
No interface changes involved.
This RIP doesn't introduce any compatibility issues.
I think there is no other cadicate alternatives.