Skip to content

Commit

Permalink
Fix failure calling json function over cxxbridge (#25898)
Browse files Browse the repository at this point in the history
Fix failure calling `json` function over `cxxbridge`

It is not entirely clear what is the underlying mechanism for this
failure, and it should be investigated further. On Windows Debug builds,
any calls to functions like `json::convert_all_numbers_to_string` were
causing a runtime crash. Bisecting our branch has revealed that this
crash started after an entirely unrelated change [1] that in fact seems
quite anodyne.

This change correct the runtime failure with a minimum change.

Resolves brave/brave-browser#41497

[1] #25830
  • Loading branch information
cdesouza-chromium authored Oct 9, 2024
1 parent 101f594 commit 4e6b460
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion browser/sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ brave_chrome_browser_deps = [
"//brave/components/ai_chat/core/common/buildflags",
"//brave/components/ai_rewriter/common/buildflags",
"//brave/components/body_sniffer",
"//brave/components/brave_adaptive_captcha",
"//brave/components/brave_ads/browser",
"//brave/components/brave_ads/core",
"//brave/components/brave_component_updater/browser",
Expand Down Expand Up @@ -503,7 +504,6 @@ if (is_win && is_official_build) {
brave_chrome_browser_public_deps = [
"//brave/app/vector_icons",
"//brave/browser:browser_process",
"//brave/components/brave_adaptive_captcha",
"//brave/components/brave_sync:constants",
"//brave/components/variations",
]
Expand Down

0 comments on commit 4e6b460

Please # to comment.