Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] Add 1.69.x translations #25527

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[iOS] Add 1.69.x translations #25527

merged 1 commit into from
Sep 11, 2024

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Sep 11, 2024

Resolves brave/brave-browser#41007

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Verify VPN screen is localized.

@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Sep 11, 2024
@nuo-xu nuo-xu requested a review from a team September 11, 2024 16:49
@nuo-xu nuo-xu self-assigned this Sep 11, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner September 11, 2024 16:49
@kylehickinson kylehickinson added CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 11, 2024
@kjozwiak kjozwiak added this to the 1.69.x - Release #6 milestone Sep 11, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.69.x approved 👍

@kjozwiak kjozwiak merged commit 2ce0345 into 1.69.x Sep 11, 2024
16 checks passed
@kjozwiak kjozwiak deleted the bugfix/41007 branch September 11, 2024 20:13
nuo-xu added a commit that referenced this pull request Sep 12, 2024
nuo-xu added a commit that referenced this pull request Sep 12, 2024
nuo-xu added a commit that referenced this pull request Sep 12, 2024
kjozwiak pushed a commit that referenced this pull request Sep 12, 2024
[iOS] Add 1.69.x translations (#25527)

add 1.69 translations
kjozwiak pushed a commit that referenced this pull request Sep 12, 2024
[iOS] Add 1.69.x translations (#25527)

add 1.69 translations
kjozwiak pushed a commit that referenced this pull request Sep 12, 2024
[iOS] Add 1.69.x translations (#25527)

add 1.69 translations
jagadeshjai pushed a commit to jagadeshjai/brave-core that referenced this pull request Sep 14, 2024
[iOS] Add 1.69.x translations (brave#25527)

add 1.69 translations
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants