Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adds 2018 Honda Fit support #266

Merged
merged 14 commits into from
Aug 27, 2019
Merged

Adds 2018 Honda Fit support #266

merged 14 commits into from
Aug 27, 2019

Conversation

energee
Copy link
Contributor

@energee energee commented Jun 19, 2018

@jfrux jfrux mentioned this pull request Jun 26, 2018
Closed
@rbiasini
Copy link
Contributor

rbiasini commented Jul 16, 2018 •
edited
Loading

@energee once conflicts are fixed, is this good to go?

@rbiasini
Copy link
Contributor

rbiasini commented Aug 7, 2018 •
edited
Loading

@energee, would love to merge this in if somebody can confirm it works

@rbiasini
Copy link
Contributor

rbiasini commented Jun 6, 2019

Still testing needed?

@energee
Copy link
Contributor Author

energee commented Jun 6, 2019

I think its close, there is a user who has it working and he may have a diff for this branch with some further changes.

@energee
Copy link
Contributor Author

energee commented Jun 6, 2019

Side note, how is this PR a year old?

@rbiasini
Copy link
Contributor

rbiasini commented Jun 6, 2019

Time flies 🤷‍♂️

@AravindaDP
Copy link

Note: Variable names in interface.py are changed between 0.5 and 0.6. So it would need refactoring before merging.
I'm currently working with a fit owner to see if this works. Will update if we could get this working on 0.6.2

AravindaDP
AravindaDP suggested changes Aug 13, 2019
View reviewed changes
Copy link

@AravindaDP AravindaDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have worked with a Fit owner to get his vehicle working on 0.6.2 based on these changes.

cabana link: https://my.comma.ai/cabana/?route=99e3eaed7396619e%7C2019-08-12--13-56-01&max=19&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F99e3eaed7396619e%2Fda964fc10ba22af53289a955fb652b43_2019-08-12--13-56-01

selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
selfdrive/car/honda/interface.py Outdated Show resolved Hide resolved
energee and others added 7 commits August 13, 2019 13:31
@energee @AravindaDP
Update cargo variable
8f56375 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee @AravindaDP
Added tire stiffness, renamed PID kp/ki variables
6dc7dc4 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee @AravindaDP
Renamed longitudinal KpBP
4a294ed 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee @AravindaDP
Renamed longitudinal kpV
bdd062b 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee @AravindaDP
Renamed longitudinal KiBP variable
4bf40df 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee @AravindaDP
Renamed longitudinal KiV
5959a81 
Co-Authored-By: Pramuditha Aravinda <pramudithaa@zone24x7.com>
@energee
Merge branch 'devel' into fit
7921fcb
@energee
Copy link
Contributor Author

energee commented Aug 13, 2019

Can we test this, @AravindaDP ?

@AravindaDP
Copy link

@energee @rbiasini

Here is the cabana drive provided by fit user for this
https://my.comma.ai/cabana/?route=99e3eaed7396619e%7C2019-08-13--15-07-03&max=0&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2F99e3eaed7396619e%2Fced4327cf0038699b7d1cbe59e5f8843_2019-08-13--15-07-03

@energee
Copy link
Contributor Author

energee commented Aug 14, 2019

@vanillagorillaa ^

@energee
Copy link
Contributor Author

energee commented Aug 14, 2019 •
edited
Loading

Can we verify tire stiffness value on some turns? probably needs some adjustment.

I would expect ts value to be around .75 - 1

pd0wm pushed a commit that referenced this pull request Jun 4, 2020
Squashed 'opendbc/' changes from e92e743..b875f97
98ababe 
b875f97 Stricter pylint
daf3bc9 HRV correct GAS_PEDAL (#266)
c25b757 Update X-trail HUD message name, added SPEED_MPH signal (#269)
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment

git-subtree-dir: opendbc
git-subtree-split: b875f97
pd0wm pushed a commit that referenced this pull request Jun 5, 2020
Squashed 'opendbc/' changes from e92e743..b875f97
a18bd33 
b875f97 Stricter pylint
daf3bc9 HRV correct GAS_PEDAL (#266)
c25b757 Update X-trail HUD message name, added SPEED_MPH signal (#269)
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment

git-subtree-dir: opendbc
git-subtree-split: b875f97
pd0wm pushed a commit that referenced this pull request Jun 6, 2020
Squashed 'opendbc/' changes from e92e743..b875f97
fc957d2 
b875f97 Stricter pylint
daf3bc9 HRV correct GAS_PEDAL (#266)
c25b757 Update X-trail HUD message name, added SPEED_MPH signal (#269)
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment

git-subtree-dir: opendbc
git-subtree-split: b875f97
pd0wm pushed a commit that referenced this pull request Jun 6, 2020
Squashed 'opendbc/' changes from e92e743..b875f97
2469d4e 
b875f97 Stricter pylint
daf3bc9 HRV correct GAS_PEDAL (#266)
c25b757 Update X-trail HUD message name, added SPEED_MPH signal (#269)
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment

git-subtree-dir: opendbc
git-subtree-split: b875f97
pd0wm pushed a commit that referenced this pull request Jun 7, 2020
Squashed 'opendbc/' changes from e92e743..b875f97
0119dcc 
b875f97 Stricter pylint
daf3bc9 HRV correct GAS_PEDAL (#266)
c25b757 Update X-trail HUD message name, added SPEED_MPH signal (#269)
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment

git-subtree-dir: opendbc
git-subtree-split: b875f97
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
@sunnyhaibin
Gap Adjust Cruise: Handle distance bar on cluster for Hyundai CAN-FD (c…
0b09c64 
…ommaai#266)
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AravindaDP AravindaDP AravindaDP requested changes

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@energee @rbiasini @AravindaDP @pd0wm