Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat CI: Add CI for stable version #10

Closed
wants to merge 45 commits into from
Closed

feat CI: Add CI for stable version #10

wants to merge 45 commits into from

Conversation

thomasgouveia
Copy link

This PR contains the necessary to run a simple CI job on our project.

Actually the CI is configured to build the application with the stable toolchain, run all tests, run cargo clippy and cargo fmt.

Missing behaviors:

  • Build the app with the nightly release
  • Build the app with the beta release

Samuel Ortiz added 30 commits February 6, 2021 14:12
README: Initial do-core1 specification
714c114 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
d0-core1: Hello world
9140799 
It always starts from here.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
d0-core1: Add 2 variables
dc29416 
Define 2 variables on the stack and add them together.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Enforce 16 bits registers
9b60cb1 
do-core1 registers are 16 bits wide.
Use Rust static typing to enforce that.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: 2-operand addition
ec80d40 
Introduce mutability by adding the addition result to the first operand.
The first operand must be defined as mutable, or else we fail to build.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Define an addition function
9d576e6 
Introduce the function syntax to abstract registers addition.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Check for the only supported opcode
e88c977 
Introduce Rust flow control (i.e. if) in order to check that we add only
when the opcode is ADD. Panic! otherwise.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add OpCode Enumeration
b763b8e 
Introduce Rust's versatile Enum for defining a new type: OpCode.
First pattern matching code path.
Pretty print the Enum value.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Shut dead code warnings off
c9cd17a 
Introduce compiler linting and actually turn it off for non supported
opcodes.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Implement the XOR instruction
8b94d78 
Live exercice #1.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Register pretty printing
d1532df 
Introduce Rust print formatting rules.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial instruction disassembler
c00eee8 
The disassembler takes a fixed 16 bits instruction and tries to decode
it into an opcode, and 2 operands.

This intentionnaly fails to build, as it needs OpCode::from_u8.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Implement OpCode::from_u8
4548168 
Introduce the impl Rust keyword, for type implementations.
Here it's an Enum.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add an Instruction structure
0dab8b5 
The Instruction constructor is a disassembler, it can not be overloaded
with other constructors.

Live exercice #2.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add first instruction unit test
83f7f46 
Introduce Rust's unit testing framework.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add more Instruction unit tests
5c55473 
We add more tests for disassembling all supported instructions.

Live exercice #3.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial command line parsing
1c25159 
Introduce external crates dependencies through the clap crate.
Rust's std library is scarce and limited, no command line parsing for
example.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial error handling
ba816dc 
Add partial error handling for the instruction disassembler.
Introduce the Result type and do basic and naive error handling (panic!
if disassemble() returns an error).

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial error pattern matching
4989db4 
Introduce Rust error pattern matching.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Handle OpCode::from_u8 error
e79bf77 
With naive pattern matching check.

Live exercice #4.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Use the ? operator
f631761 
Simple example showing how the ? operator replaces the previous naive
patter matching.
Show how errors can be forwarded all the way up to main.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Report addition overflow errors
973dd69 
Introduce the Option type.
Show how to convert an Option to a Result and carry errors forward.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Fix unit tests
4e11edf 
All broken after adding the error handling code.

Live exercice #5.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add negative unit tests
60d6647 
Now that we know if disassembling reported an error or not, we can
implement negative unit testing.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Define a registers array
9ac5ad7 
In order to manipulate more than R0 and R1, we define a static array of
8 u16 values.
Introduce Rust collection (A simple array).

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Add a routine for dumping a do-core1 CPU state
c21cb86 
Now that we have a complete set of registers, it is more convenient to
be able to print all of them.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial arbitrary registers initialization
626d130 
This is temporary. Eventually, there will be a Cpu constructor, and
potentially register initialization through memory loads.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Initial do-core crate
1453f13 
With a minimal content, just our opcodes.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: First do-core usage
cea21e9 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Move Instruction to the do-core crate
de1a5fd 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Samuel Ortiz and others added 15 commits March 7, 2021 23:46
do-core1: do-core: Add opcode and operand getters
348ea0f 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Move instruction unit tests to do-core
fbccc78 
And define a workspace.

Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core1: Move our core implementations to do-core
cae98d7 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core: Add Core unit tests
4701d0c 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core: Initial memory implementation
11f8f0b 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core: memory: Add unit tests
75926f0 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core: core: Implement LD and ST
c5b39ef 
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
do-core: instruction: Implement FromStr for OpCode
bce393c 
Related issue: #3
This is for do-core-asm to be able to depend on us for its opcodes needs

Signed-off-by: Eliott Veyrier <eliott.veyrier@umontpellier.fr>
do-core : run cargo fmt
90bc5b7 
Signed-off-by: Eliott Veyrier <eliott.veyrier@umontpellier.fr>
feat : Basic CI
8e484ee
fix CI : use workspace option for tests
2c1c9d6
feat CI : add clippy lint
f11847a
fix CI: typo in build.yml
25a8afb
feat CI: add format command
8b976ef
fix CI : clippy action
08e05e0
@thomasgouveia thomasgouveia mentioned this pull request Mar 23, 2021
Open
sameo
sameo reviewed Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@sameo sameo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasgouveia Thanks a lot for the PR.

Could we please reorganize the commits in order to only have 3 of them:

  1. The basic github action (with all 3 toolchains)
  2. The cargo fmt addition
  3. The cargo clippy one with the actual code fixes

@thomasgouveia thomasgouveia closed this by deleting the head repository Oct 22, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sameo sameo sameo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasgouveia @sameo