-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for deposit to the DSpace REST API #135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fec504f
to
d4a366b
Compare
6ce178a
to
d750107
Compare
5bf461e
to
c84a802
Compare
…guration properties.
94a9f14
to
d34fdf5
Compare
rpoet-jh
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, Mark! Just a few comments, but in general it looks good. I still need to test and review the other PRs, but this is a first pass at the review for this main PR.
...posit-core/src/main/java/org/eclipse/pass/deposit/provider/j10p/DspaceMetadataDomWriter.java
Show resolved
Hide resolved
...services/deposit-core/src/main/java/org/eclipse/pass/deposit/provider/util/CitationUtil.java
Show resolved
Hide resolved
...services/deposit-core/src/main/java/org/eclipse/pass/deposit/provider/util/CitationUtil.java
Show resolved
Hide resolved
...eposit-services/deposit-core/src/main/java/org/eclipse/pass/deposit/service/DepositTask.java
Outdated
Show resolved
Hide resolved
...deposit-core/src/main/java/org/eclipse/pass/deposit/support/dspace/DSpaceDepositService.java
Outdated
Show resolved
Hide resolved
...deposit-core/src/main/java/org/eclipse/pass/deposit/support/dspace/DSpaceDepositService.java
Show resolved
Hide resolved
...ices/deposit-core/src/main/java/org/eclipse/pass/deposit/transport/dspace/DSpaceSession.java
Outdated
Show resolved
Hide resolved
...deposit-core/src/main/java/org/eclipse/pass/deposit/support/dspace/DSpaceDepositService.java
Outdated
Show resolved
Hide resolved
...deposit-core/src/main/java/org/eclipse/pass/deposit/support/dspace/DSpaceDepositService.java
Show resolved
Hide resolved
...ices/deposit-core/src/main/java/org/eclipse/pass/deposit/transport/dspace/DSpaceSession.java
Outdated
Show resolved
Hide resolved
rpoet-jh
reviewed
Feb 7, 2025
...ices/deposit-core/src/main/java/org/eclipse/pass/deposit/transport/dspace/DSpaceSession.java
Outdated
Show resolved
Hide resolved
rpoet-jh
reviewed
Feb 7, 2025
...ices/deposit-core/src/main/java/org/eclipse/pass/deposit/transport/dspace/DSpaceSession.java
Outdated
Show resolved
Hide resolved
…ake the connection verification for DSpace more robust.
rpoet-jh
reviewed
Feb 11, 2025
...it-core/src/test/java/org/eclipse/pass/deposit/provider/dspace/DSpaceMetadataMapperTest.java
Show resolved
Hide resolved
rpoet-jh
reviewed
Feb 11, 2025
...deposit-core/src/main/java/org/eclipse/pass/deposit/support/dspace/DSpaceDepositService.java
Outdated
Show resolved
Hide resolved
rpoet-jh
approved these changes
Feb 11, 2025
rpoet-jh
reviewed
Feb 11, 2025
...es/deposit-core/src/main/java/org/eclipse/pass/deposit/transport/dspace/DSpaceTransport.java
Outdated
Show resolved
Hide resolved
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new deposit option is added which uses the DSpace REST API.
Also:
DSpace deposit takes three calls and tries to handle resumption after an error in the last two calls.
Operational changes:
Required prs:
Related prs:
Test by building the pass-core, pass-ui, and pass-support prs. Then using the pass-docker pr, start up PASS with dspace support. Finally attempt to do some deposits and verify that they work. You should notice that publication date is now required.
Notes on interacting directly with the DSpace REST API:
Generate a CSRF token. Note that this endpoint returns 404.
Login and get the auth token
Create a workspace item
See workspace items
Set required metadata
Create a workflow item for workspace item
Example of patch