Session info #230
Merged
Session info #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'breaking-change', 'internal', 'documentation', 'new feature', 'enhancement', 'bug'} |
DariusIMP
added
enhancement
wyfo
reviewed
Sep 19, 2024
| /** | ||
| * Class allowing to obtain the information of a [Session]. | ||
| */ | ||
| class SessionInfo(private val session: Session) { |
There was a problem hiding this comment.
Why using Session instead of SessionInfo?
There was a problem hiding this comment.
I'll let @wyfo and @DariusIMP decide if this comment is a blocker for this PR. Otherwise it LGTM.
wyfo
reviewed
Sep 19, 2024
| /** | ||
| * Return the [ZenohID] of the current Zenoh [Session] | ||
| */ | ||
| fun id(): Result<ZenohID> { |
There was a problem hiding this comment.
Suggested change
| fun id(): Result<ZenohID> { | |
| fun zid(): Result<ZenohID> { |
| /** | ||
| * Return the [ZenohID] of the zenoh peers the session is currently connected to. | ||
| */ | ||
| fun peersId(): Result<List<ZenohID>> { |
There was a problem hiding this comment.
Suggested change
| fun peersId(): Result<List<ZenohID>> { | |
| fun peersZid(): Result<List<ZenohID>> { |
| /** | ||
| * Return the [ZenohID] of the zenoh routers the session is currently connected to. | ||
| */ | ||
| fun routersId(): Result<List<ZenohID>> { |
There was a problem hiding this comment.
Suggested change
| fun routersId(): Result<List<ZenohID>> { | |
| fun routersZid(): Result<List<ZenohID>> { |
|
|
||
| package io.zenoh | ||
|
|
||
| import io.zenoh.protocol.ZenohID |
There was a problem hiding this comment.
ZenohID should be renamed ZenohId to align
There was a problem hiding this comment.
Opened PR #233 for this, to be merged after this one.
Mallets
approved these changes
Sep 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
SessionInfoclass with the following functions:fun id(): Result<ZenohID>fun peers(): Result<List<ZenohID>>fun routers(): Result<List<ZenohID>>A Result.failure is returned in case of either:
Also, added the ZInfo example.