feat(spans): Produce items from process-segments #91714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
|
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...sentry/spans/consumers/process_segments/convert.py | 86.27% | 7 Missing |
Additional details and impacted files
@@ Coverage Diff @@
## master #91714 +/- ##
==========================================
+ Coverage 83.79% 87.68% +3.89%
==========================================
Files 10361 10343 -18
Lines 587529 586778 -751
Branches 22595 22469 -126
==========================================
+ Hits 492298 514523 +22225
+ Misses 94810 71816 -22994
- Partials 421 439 +18 
* master: (58 commits) link: cleanup link (#91687) ref: create project_id index for organizationonboardingtask (#91918) storybook: smaller last edited (#91875) issues: fix chonk stacktrace alignment (#91891) alert: drop custom alert (#91892) insights: fix bar height (#91895) ref(span-buffer): Move max-memory-percentage to right CLI (#91924) ref(js): Factor button functionality (#91763) tests(resolve_groups): Clean up the tests (#91779) ref(span-buffer): Add backpressure (#91707) fix(nextjs-insights): project id is not passed to explore link (#91920) fix(crons): Floor seconds / microsecond on recorded dateClock (#91890) fix(uptime): Fix bug with the uptime_checks dataset in the events endpoint (#91824) ref: add state-only migration to reflect existing indexes in prod (#91901) ref: remove unnecssary metaclass (#91906) fix(stats): use data category title name (#91913) feat(issues): Add success messages to some actions (#91899) test(taskworker): Lower exec time (#91907) chore(aci): manually add spans for delayed workflow processing (#91908) chore(aci): remove uses of WorkflowFireHistory rollout columns (#91904) ...
5 tasks
jan-auer
reviewed
May 21, 2025
| def _timestamp(value: float) -> Timestamp: | ||
| return Timestamp( | ||
| seconds=int(value), | ||
| nanos=round((value % 1) * 1_000_000) * 1000, |
There was a problem hiding this comment.
We map timestamps with full available precision. EAP will truncate those, but we do not do this here to reduce coupling.
| "description": "sentry.raw_description", | ||
| "duration_ms": "sentry.duration_ms", | ||
| "is_segment": "sentry.is_segment", | ||
| "exclusive_time_ms": "sentry.exclusive_time_ms", |
There was a problem hiding this comment.
exclusive_time_ms was not part of the Relay implementation, but eap_items_span converted this field. @phacops do we need this or should we actually map exclusive_time?
There was a problem hiding this comment.
I think the product adapted to reading sentry.exclusive_time_ms (
sentry/src/sentry/utils/snuba.py
Line 203 in afcaf89
| "received": "sentry.received", | ||
| "origin": "sentry.origin", | ||
| "kind": "sentry.kind", | ||
| "hash": "sentry.hash", |
There was a problem hiding this comment.
This field is written in enrichment. We use this for performance issue detection and used to persist it.
jan-auer
changed the title
phacops
approved these changes
May 21, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/getsentry/streaming-planning/issues/144
cc @phacops