Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(payment_methods_v2): Payment methods v2 API models #5564

Merged
merged 25 commits into from
Aug 26, 2024

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Aug 7, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

API models for payment methods v2

  • Implemented types for API v2
  • Have left a todo! macro for functions where v2 implementation is unclear

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Logic can't be tested as of now as this PR is only concerned with API model change

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Sarthak1799 Sarthak1799 self-assigned this Aug 7, 2024
@Sarthak1799 Sarthak1799 requested review from a team as code owners August 7, 2024 19:00
@Sarthak1799 Sarthak1799 linked an issue Aug 7, 2024 that may be closed by this pull request
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 7, 2024
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner August 7, 2024 19:17
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Show resolved Hide resolved
@Sarthak1799 Sarthak1799 added A-core Area: Core flows A-payment-methods Area: Payment Methods api-v2 labels Aug 9, 2024
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 14, 2024
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
crates/api_models/src/payment_methods.rs Outdated Show resolved Hide resolved
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner August 22, 2024 13:06
jarnura
jarnura previously approved these changes Aug 22, 2024
ThisIsMani
ThisIsMani previously approved these changes Aug 22, 2024
Copy link
Contributor

@ThisIsMani ThisIsMani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth specific changes looks fine.

jarnura
jarnura previously approved these changes Aug 22, 2024
@hyperswitch-bot hyperswitch-bot bot dismissed stale reviews from ThisIsMani and jarnura via be4bee6 August 22, 2024 14:26
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 22, 2024
ThisIsMani
ThisIsMani previously approved these changes Aug 22, 2024
jarnura
jarnura previously approved these changes Aug 22, 2024
@Sarthak1799 Sarthak1799 dismissed stale reviews from jarnura and ThisIsMani via 07979b9 August 22, 2024 16:26
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit e98ff95 Aug 26, 2024
18 checks passed
@likhinbopanna likhinbopanna deleted the pm-models-v2 branch August 26, 2024 07:14
pixincreate added a commit that referenced this pull request Aug 26, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
pixincreate added a commit that referenced this pull request Aug 27, 2024
* 'main' of github.com:juspay/hyperswitch: (134 commits)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
  feat(connector): [Adyen] add dispute flows for adyen connector (#5514)
  chore(version): 2024.08.23.0
  ...
pixincreate added a commit that referenced this pull request Aug 27, 2024
…-key-check

* 'main' of github.com:juspay/hyperswitch:
  feat(core): Add mTLS certificates for each request (#5636)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods api-v2 M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement API models for Payment methods v2
5 participants