Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(connector): [NOVALNET] Add template code #5670

Merged
merged 1 commit into from
Aug 27, 2024
Merged

feat(connector): [NOVALNET] Add template code #5670

merged 1 commit into from
Aug 27, 2024

Conversation

ghost
Copy link

@ghost ghost commented Aug 22, 2024 •
edited by ghost
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Template code added for new connector Novalnet
https://developer.novalnet.com/onlinepayments/api

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ghost ghost requested review from a team as code owners August 22, 2024 12:18
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 22, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 7 of 25 files.

Overall, the semantic diff is 7% smaller than the GitHub diff.

File Information
Filename Status
❔ scripts/add_connector.sh Unsupported file format
❔ loadtest/config/development.toml Unsupported file format
❔ crates/test_utils/src/connector_auth.rs Unsupported file format
❔ crates/router/tests/connectors/main.rs Unsupported file format
❔ crates/router/tests/connectors/novalnet.rs Unsupported file format
❔ crates/router/tests/connectors/sample_auth.toml Unsupported file format
❔ crates/router/src/connector.rs Unsupported file format
✔️ crates/router/src/types/api.rs Analyzed
✔️ crates/router/src/types/transformers.rs Analyzed
✔️ crates/router/src/core/payments/connector_integration_v2_impls.rs 10.12% smaller
❔ crates/router/src/core/payments/flows.rs Unsupported file format
❔ crates/hyperswitch_interfaces/src/configs.rs Unsupported file format
❔ crates/hyperswitch_connectors/src/connectors.rs Unsupported file format
✔️ crates/hyperswitch_connectors/src/default_implementations.rs 6.95% smaller
✔️ crates/hyperswitch_connectors/src/default_implementations_v2.rs 6.86% smaller
❔ crates/hyperswitch_connectors/src/connectors/novalnet.rs Unsupported file format
❔ crates/hyperswitch_connectors/src/connectors/novalnet/transformers.rs Unsupported file format
✔️ crates/common_enums/src/enums.rs Analyzed
✔️ crates/api_models/src/enums.rs Analyzed
❔ config/config.example.toml Unsupported file format
❔ config/development.toml Unsupported file format
❔ config/docker_compose.toml Unsupported file format
❔ config/deployments/integration_test.toml Unsupported file format
❔ config/deployments/production.toml Unsupported file format
❔ config/deployments/sandbox.toml Unsupported file format

deepanshu-iiitu
deepanshu-iiitu requested changes Aug 22, 2024
View reviewed changes
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/api_models/src/enums.rs Outdated Show resolved Hide resolved
crates/hyperswitch_connectors/src/default_implementations.rs Outdated Show resolved Hide resolved
crates/hyperswitch_connectors/src/default_implementations_v2.rs Outdated Show resolved Hide resolved
crates/router/src/core/admin.rs Outdated Show resolved Hide resolved
crates/router/src/types/api.rs Outdated Show resolved Hide resolved
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 22, 2024
@ghost ghost force-pushed the novalnetSetup branch from ec42e80 to 330955f Compare August 22, 2024 16:49
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 22, 2024
@ghost ghost force-pushed the novalnetSetup branch from baf5cdc to b6a85b0 Compare August 22, 2024 17:26
@hyperswitch-bot hyperswitch-bot bot added M-api-contract-changes Metadata: This PR involves API contract changes and removed M-api-contract-changes Metadata: This PR involves API contract changes labels Aug 22, 2024
@ghost ghost force-pushed the novalnetSetup branch from c38b262 to de25f71 Compare August 22, 2024 19:03
@hyperswitch-bot hyperswitch-bot bot removed the M-api-contract-changes Metadata: This PR involves API contract changes label Aug 22, 2024
@ghost ghost force-pushed the novalnetSetup branch from de25f71 to 6279503 Compare August 22, 2024 19:08
deepanshu-iiitu
deepanshu-iiitu requested changes Aug 23, 2024
View reviewed changes
crates/router/src/types/api.rs Outdated Show resolved Hide resolved
@ghost ghost force-pushed the novalnetSetup branch from 6279503 to ebd3a1d Compare August 23, 2024 07:14
@ghost ghost linked an issue Aug 23, 2024 that may be closed by this pull request
[FEATURE] Add template code for Novalnet #5683
Closed
2 tasks
@ghost ghost force-pushed the novalnetSetup branch from ebd3a1d to d9d4d1b Compare August 23, 2024 10:22
@SanchithHegde SanchithHegde assigned ghost Aug 26, 2024
@SanchithHegde SanchithHegde added the A-connector-integration Area: Connector integration label Aug 26, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit c3c9b27 Aug 27, 2024
14 checks passed
@likhinbopanna likhinbopanna deleted the novalnetSetup branch August 27, 2024 07:18
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-auto-retry
b8d6398 
* 'main' of github.com:juspay/hyperswitch:
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-cypress-ci
3c2515e 
* 'main' of github.com:juspay/hyperswitch: (134 commits)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
  feat(connector): [Adyen] add dispute flows for adyen connector (#5514)
  chore(version): 2024.08.23.0
  ...
pixincreate added a commit that referenced this pull request Aug 27, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into cypress-api…
3bb8643 
…-key-check

* 'main' of github.com:juspay/hyperswitch:
  feat(core): Add mTLS certificates for each request (#5636)
  refactor(open_banking): Added merchant data update in mca update (#5655)
  feat: add test_mode for quickly testing payout links (#5669)
  refactor: introduce a domain type for profile ID (#5687)
  ci(cypress): update paybox configs (#5664)
  feat(openapi):  Add open api routes for routing v2 (#5686)
  feat(connector): [NOVALNET] Add template code (#5670)
  feat(user): business email update (#5674)
  chore(config): add production connector-configs for netcetera external 3ds flow (#5698)
  chore(version): 2024.08.27.0
  refactor(euclid): make the disabled node's relation as negative (#5701)
  feat: populate payment method details in payments response (#5661)
  build(deps): bump `diesel` to `2.2.3` and `sqlx` to `0.8.1` (#5688)
  feat(customer_v2):  added list customer v2 end point (#5517)
  feat(business_profile): add tax_connector_id column in business_profile table (#5576)
  chore: create v2 route for organization (#5679)
  refactor(payments_response): remove setter from payments response (#5676)
  feat(payment_methods_v2): Payment methods v2 API models (#5564)
  chore(version): 2024.08.26.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add template code for Novalnet
5 participants
@SanchithHegde @deepanshu-iiitu @sai-harsha-vardhan @likhinbopanna @cookieg13