Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

merge action: add check for required status before attempting to merge #386

Closed
shine2lay opened this issue Sep 22, 2020 · 3 comments
Closed

merge action: add check for required status before attempting to merge #386

shine2lay opened this issue Sep 22, 2020 · 3 comments

Comments

@shine2lay
Copy link
Member

We are not checking required statuses currently before merging, as a result, when a new commit is pushed to PR and other required status (e.g circle ci) not finished, it'll throw error
@shine2lay shine2lay mentioned this issue Sep 29, 2020
Merged
shine2lay added a commit to shine2lay/mergeable that referenced this issue Oct 2, 2020
@shine2lay
Merge branch 'master' into mergeability#386
c07614d
shine2lay added a commit that referenced this issue Oct 2, 2020
@shine2lay
Merge pull request #389 from shine2lay/#386
eb35e74 
fix: don't throw error if required status is not done
@jusx jusx mentioned this issue Oct 6, 2020
Closed
@sambhav
Copy link
Contributor

sambhav commented Oct 8, 2020

Fixed in #400. We can close this now.

@sambhav sambhav mentioned this issue Oct 8, 2020
Open
@sambhav
Copy link
Contributor

sambhav commented Oct 8, 2020

@shine2lay @jusx can we close this please?

@jusx
Copy link
Member

jusx commented Oct 8, 2020

fixed in #400

@jusx jusx closed this as completed Oct 8, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wip] feat: Add the ability to auto merge PRs sambhav/mergeable
3 participants
@jusx @shine2lay @sambhav