Skip to content

fix: don't throw error if required status is not done #389

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

shine2lay
Copy link
Member

@shine2lay shine2lay commented Sep 29, 2020

There weren't any API to check if all required status is done so the solution implemented here is to just not throw error if we see this specific type of error

@sambhav
Copy link
Contributor

sambhav commented Oct 2, 2020

This currently also fails in case one of the required branch checks is that the branch should be up to date or if the branch needs reviewers.

@sambhav
Copy link
Contributor

sambhav commented Oct 2, 2020

We should be checking for https://docs.github.com/en/free-pro-team@latest/rest/reference/repos#get-the-combined-status-for-a-specific-reference, I can make a PR soon.

@jusx
Copy link
Member

jusx commented Oct 2, 2020

@samj1912 Great catch. Looking forward to your PR.

@shine2lay
Copy link
Member Author

@jusx @samj1912 I'll merge this in for a temporary solution, left the issue open for when you open your PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants