fix: Do not attempt to merge a pull request if the status is blocked #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
force-pushed
the
merge-status-fix
branch
from
5212f5a to
833718f
Compare
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 94.16% 93.81% -0.36%
==========================================
Files 72 73 +1
Lines 1578 1665 +87
Branches 301 326 +25
==========================================
+ Hits 1486 1562 +76
- Misses 81 90 +9
- Partials 11 13 +2
Continue to review full report at Codecov.
|
sambhav
force-pushed
the
merge-status-fix
branch
from
833718f to
5009cd4
Compare
sambhav
force-pushed
the
merge-status-fix
branch
from
5009cd4 to
02641cb
Compare
|
@jusx @shine2lay can you also take a look at this - it is an important fix. Currently mergeable also merges closed PRs if all the checks pass. |
|
@samj1912 Could you please resolve the conflict? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split out the fix for #389 from #394
This has the required test and doc fixes for #389
@jusx @shine2lay please review and merge this before #394