-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update docker image to humble #165
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
This reverts commit 5b49845.
Thanks for updating the docker build process and migrating it to humble. 2 questions straight out of my mind:
|
I think managing multiple releases is a good idea if we want to continue supporting galactic.
That's a great question, I would like to reduce duplication as well, which is why I reuse the image from the deployment example. A problem with the example images now is that it builds all of rmf in a single image and each component just have a different entry point. I think it will be a good idea to have a universal builder image that can be used by all other rmf repos and have each component build only the packages it needs. The question though is if we should spread all the dockerfile to each repos or consolidate them all in one repo 🤔 . |
I agree that it is a good idea to use a common dockerfile across multiple rmf project. I have updated the dockerfiles in |
Currently we have a similar CI here. We can indicate the img's ros distro with either -
name: Build builder-rosdep
uses: docker/build-push-action@v3
with:
context: .
file: rmf-dockerfiles/rmf/builder-rosdep.Dockerfile
build-args: |
BASE_REGISTRY=${{ env.base_registry }}
ROS_DISTRO=galactic
push: true
tags: ${{ env.builder_ns }}/builder-rosdep:latest Maybe just update the CI here to utilize the dockerfiles in |
Yeah, open-rmf/rmf_traffic_editor#439 is blocking |
@@ -0,0 +1,15 @@ | |||
repositories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should keep the .repos file here or use the ones in the deployment repo, for example for simulation and main rmf.
From what I understand they are going to be the same, so we can avoid maintaining them in both repos?
Removing them would reduce duplication but would cause quite some trouble since all downstream actions would have to change the url of their vcs file, so I can see arguments both ways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the repos file should not be the same. These repos file here tracks the branch which makes it very problematic for reproducible builds and deployments. That does mean we will have to maintain multiple copies of each repos file 😞 .
thirdparty/ros_ign: | ||
type: git | ||
url: https://github.com/ignitionrobotics/ros_ign.git | ||
version: galactic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going for a split of rmf.repos
into deployment and simulation files we should probably remove rmf_simulation
, menge_vendor
and rmf_demos
from this file.
``` | ||
|
||
### RMF Demos | ||
|
||
A good way to install the `rmf` set of packages in one go is to install the one of the main [RMF Demos](https://github.com/open-rmf/rmf_demos) packages. This will pull all the rest of the OpenRMF packages as a dependency. The core of RMF demos is contained on the `rmf_demos` package. However, if you want to install it with simulation support, you should install the `rmf_demos_gz` or `rmf_demos_ign` package which come with gazebo or ignition support respectively. As an example, to install the ROS 2 Galactic release with gazebo support package, you would run: | ||
A good way to install the `rmf` set of packages in one go is to install the one of the main [RMF Demos](https://github.com/open-rmf/rmf_demos) packages. This will pull all the rest of the OpenRMF packages as a dependency. The core of RMF demos is contained on the `rmf_demos` package. However, if you want to install it with simulation support, you should install the `rmf_demos_gz` or `rmf_demos_ign` package which come with gazebo or ignition support respectively. As an example, to install the ROS 2 Humble release with gazebo support package, you would run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once it is finalized (i.e. this is merged) we should probably update this to the Gazebo renaming (ign -> gz
and gz -> gz_classic
)
@@ -26,18 +26,18 @@ wget https://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add - | |||
|
|||
## Binary install | |||
|
|||
OpenRMF binary packages are available for Ubuntu Focal 20.04 for the `Foxy`, `Galactic` and `Rolling` releases of ROS 2. Most OpenRMF packages have the prefix `rmf` on their name, therefore, you can find them by them by searching for the pattern `ros-<ro2distro>-rmf`, e.g., for galatic it would be: | |||
Latest OpenRMF binary packages are available for Ubuntu Jammy 22.04 for the `Humble` and `Rolling` releases of ROS 2. Older releases are also available on Ubuntu Focal 20.04 for `Foxy` and `Galactic`. Most OpenRMF packages have the prefix `rmf` on their name, therefore, you can find them by them by searching for the pattern `ros-<ro2distro>-rmf`, e.g., for galatic it would be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, for galatic
-> for humble
Update docker image to humble