Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding package maintainers and authors #48

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Adding package maintainers and authors #48

merged 3 commits into from
Apr 24, 2023

Conversation

quarkytale
Copy link
Contributor

@quarkytale quarkytale commented Apr 19, 2023 •
edited
Loading

Apologies again if I missed or miscredited anyone 🙏

Notes:

  • Michael and Rhys made some changes which were moved/deleted so added them (and others) in the meta-package
  • Rich would be in sim_pblog

@quarkytale
adding package maintainers and authors
843d165 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@quarkytale quarkytale linked an issue Apr 19, 2023 that may be closed by this pull request
Update maintainers osrf/mbari_wec#40
Closed
@quarkytale quarkytale marked this pull request as ready for review April 19, 2023 03:08
mabelzhang
mabelzhang reviewed Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the credits for everyone!

I would suggest everyone to check the list and make sure their credits are how they want them to appear @hamilton8415 @andermi @srmainwaring , both this PR and osrf/mbari_wec_gz#141

buoy_msgs/package.xml Outdated Show resolved Hide resolved
@quarkytale @mabelzhang
Update buoy_msgs/package.xml
90447d6 
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
mabelzhang
mabelzhang approved these changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Feel free to merge unless there's dissent - can always correct later.

@quarkytale quarkytale merged commit 5f053c9 into main Apr 24, 2023
@quarkytale quarkytale deleted the update_maintainers branch April 24, 2023 20:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mabelzhang mabelzhang mabelzhang approved these changes

@andermi andermi Awaiting requested review from andermi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update maintainers
2 participants
@quarkytale @mabelzhang