Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Sophos XG devices #1239

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Add support for Sophos XG devices #1239

merged 1 commit into from
Sep 12, 2024

Conversation

phibos
Copy link
Contributor

@phibos phibos commented Aug 29, 2024

This adds support for Sophos XG devices. But it depends on PR #1234 to be merged to parse the expiry dates of the licenses. I will rebase it when #1234 has been merged.

Signed-off-by: PhiBo <phibo@dinotools.org>
@phibos phibos marked this pull request as ready for review September 3, 2024 06:08
@SuperQ SuperQ merged commit f1e5797 into prometheus:main Sep 12, 2024
6 checks passed
@phibos phibos deleted the sophos_xg branch September 12, 2024 12:27
@phibos
Copy link
Contributor Author

phibos commented Sep 12, 2024

Thanks

@valdirjunior011
Copy link

hi @phibos I just found your PR to add support to Sophos, maybe I'm doing something wrong but datetime_patern is getting an error.

s=2024-09-21T16:12:25.871Z caller=main.go:220 level=error msg="Error parsing config file" err="yaml: unmarshal errors:\n line 29865: field datetime_pattern not found in type config.Metric\n line 30271: field datetime_pattern not found in type config.Metric\n

@SuperQ
Copy link
Member

SuperQ commented Sep 21, 2024

This feature is in main and has not been released yet.

@valdirjunior011
Copy link

hmmm ok!
thanks for the fast reply

SuperQ added a commit that referenced this pull request Jan 3, 2025
BREAKING CHANGES:

This version of the exporter introduces a cleaned up default snmp.yml that moved all
ucd-snmp-mib oids into a separate module.

If you used one of the following modules:
* synology
* ddwrt
* kemp_loadmaster 

you will need to change your scrape config to also include the ucd_la_table module as well.
See https://github.com/prometheus/snmp_exporter/tree/main?tab=readme-ov-file#multi-module-handling for further instructions.

* [CHANGE] generator: Update generator default MIBOPTS #1231
* [CHANGE] adopt log/slog, drop go-kit/log #1249
* [ENHANCEMENT] generator: Improve config error message #1274
* [FEATURE] add ParseDateAndTime type #1234 
* [FEATURE] Set UseUnconnectedUDPSocket option if one of the modules has if set #1247
* [FEATURE] add NTPTimeStamp type #1315
* [BUGFIX] fixed dashboard mixins #1319

snmp.yml changes:
* cleanup ucd-snmp-mibs #1200
  * moved oids from synology,ddwrt and kemp_loadmaster to new module ucd_la_table 
* Added support for Sophos XG Series #1239
* Added support for HPE #1267
* Added support for powercom #1275
* Added support for Cisco IMC #1293
* Updated mib for apc #1303
* Added support for TPLink DDM #1304

---------

Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Signed-off-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants