Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add NTPTimeStamp type #1315

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Add NTPTimeStamp type #1315

merged 1 commit into from
Dec 24, 2024

Conversation

@phibos phibos marked this pull request as draft December 13, 2024 11:01
@phibos phibos marked this pull request as ready for review December 13, 2024 11:19
Parse the ntp timestamp and convert it to an unix timestamp

Signed-off-by: PhiBo <phibo@dinotools.org>
Copy link
Member

@bastischubert bastischubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastischubert bastischubert merged commit 0f4ef2f into prometheus:main Dec 24, 2024
6 checks passed
@SuperQ
Copy link
Member

SuperQ commented Dec 24, 2024

Nice!

@phibos phibos deleted the ntp_timestamp branch December 27, 2024 07:35
SuperQ added a commit that referenced this pull request Jan 3, 2025
BREAKING CHANGES:

This version of the exporter introduces a cleaned up default snmp.yml that moved all
ucd-snmp-mib oids into a separate module.

If you used one of the following modules:
* synology
* ddwrt
* kemp_loadmaster 

you will need to change your scrape config to also include the ucd_la_table module as well.
See https://github.com/prometheus/snmp_exporter/tree/main?tab=readme-ov-file#multi-module-handling for further instructions.

* [CHANGE] generator: Update generator default MIBOPTS #1231
* [CHANGE] adopt log/slog, drop go-kit/log #1249
* [ENHANCEMENT] generator: Improve config error message #1274
* [FEATURE] add ParseDateAndTime type #1234 
* [FEATURE] Set UseUnconnectedUDPSocket option if one of the modules has if set #1247
* [FEATURE] add NTPTimeStamp type #1315
* [BUGFIX] fixed dashboard mixins #1319

snmp.yml changes:
* cleanup ucd-snmp-mibs #1200
  * moved oids from synology,ddwrt and kemp_loadmaster to new module ucd_la_table 
* Added support for Sophos XG Series #1239
* Added support for HPE #1267
* Added support for powercom #1275
* Added support for Cisco IMC #1293
* Updated mib for apc #1303
* Added support for TPLink DDM #1304

---------

Signed-off-by: Sebastian Schubert <basti@schubert.digital>
Signed-off-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants