chore: fix dashboard mixins that fail due beeing editable #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schubert <basti@schubert.digital>
|
Lgtm
Sent by mobile; please excuse my brevity.
…On Sun, Dec 22, 2024, 23:43 bastischubert ***@***.***> wrote:
@bastischubert <https://github.com/bastischubert> requested your review
on: #1319 <#1319> chore:
fix dashboard mixins that fail due beeing editable.
—
Reply to this email directly, view it on GitHub
<#1319 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFYII7E4H5F6D5GAOMCYI32G4575AVCNFSM6AAAAABUCBZIAWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG42DENJQGA4TAOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
SuperQ
added a commit
that referenced
this pull request
Jan 3, 2025
BREAKING CHANGES: This version of the exporter introduces a cleaned up default snmp.yml that moved all ucd-snmp-mib oids into a separate module. If you used one of the following modules: * synology * ddwrt * kemp_loadmaster you will need to change your scrape config to also include the ucd_la_table module as well. See https://github.com/prometheus/snmp_exporter/tree/main?tab=readme-ov-file#multi-module-handling for further instructions. * [CHANGE] generator: Update generator default MIBOPTS #1231 * [CHANGE] adopt log/slog, drop go-kit/log #1249 * [ENHANCEMENT] generator: Improve config error message #1274 * [FEATURE] add ParseDateAndTime type #1234 * [FEATURE] Set UseUnconnectedUDPSocket option if one of the modules has if set #1247 * [FEATURE] add NTPTimeStamp type #1315 * [BUGFIX] fixed dashboard mixins #1319 snmp.yml changes: * cleanup ucd-snmp-mibs #1200 * moved oids from synology,ddwrt and kemp_loadmaster to new module ucd_la_table * Added support for Sophos XG Series #1239 * Added support for HPE #1267 * Added support for powercom #1275 * Added support for Cisco IMC #1293 * Updated mib for apc #1303 * Added support for TPLink DDM #1304 --------- Signed-off-by: Sebastian Schubert <basti@schubert.digital> Signed-off-by: Sebastian Schubert <16682281+bastischubert@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing mixin dashboard after this change in the upstream linter: grafana/dashboard-linter@df1b122