Add support for AUTH #1929
Merged
Add support for AUTH #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 100 100
Lines 20910 20921 +11
=======================================
+ Hits 19368 19379 +11
Misses 1542 1542
Continue to review full report at Codecov.
|
|
@dogukanteber I've pushed a couple of changes, and merged master in. I realize that in master we did a raise NotImplemented for this. But - you've implemented it, and I can see reasons to do so. tl;dr - working with this, let's get it in! We're almost there. |
|
Awesome @chayim. Thanks for the changes by the way. I did not see raise NotImplemented. |
|
@dogukanteber I've pushed a small change to fix the cluster tests and now it's ready to merge. Thanks! |
dvora-h
approved these changes
Mar 2, 2022
dvora-h
added a commit
to dvora-h/redis-py
that referenced
this pull request
Mar 6, 2022
* Add support for AUTH * Fix linter error * test fix * fix test in cluster Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: dvora-h <dvora.heller@redis.com>
dvora-h
added a commit
that referenced
this pull request
Mar 6, 2022
* command docs * Add support for AUTH (#1929) * Add support for AUTH * Fix linter error * test fix * fix test in cluster Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: dvora-h <dvora.heller@redis.com> * Add support for JSON, TIMESERIES, BLOOM & GRAPH commands in cluster (#2032) Co-authored-by: Chayim <chayim@users.noreply.github.com> * Add support for HSET items (#2006) * Add `items` parameter to `hset` * Add test for `hset` with `items` * Update CHANGES * fix test_profile Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: dvora-h <dvora.heller@redis.com> * Add cluster support for functions (#2016) * cluster support for functions * fix test_list_on_cluster mark * fix mark * cluster unstable url * fix * fix cluster url * skip tests * linters * linters * skip test Co-authored-by: Chayim <chayim@users.noreply.github.com> Co-authored-by: dogukanteber <47397379+dogukanteber@users.noreply.github.com> Co-authored-by: Chayim I. Kirshen <c@kirshen.com> Co-authored-by: Marek Czaplicki <mdczaplicki@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #1546, I have implemented AUTH command.