Skip to content

Implemented COMMAND DOCS by always throwing NotImplementedError #2020

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Mar 6, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 24, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1946

@dvora-h dvora-h requested a review from chayim February 24, 2022 13:07
@dvora-h dvora-h added feature New feature redis-7 labels Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #2020 (d323b92) into master (a77df17) will decrease coverage by 0.39%.
The diff coverage is 52.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2020      +/-   ##
==========================================
- Coverage   92.60%   92.20%   -0.40%     
==========================================
  Files         100      100              
  Lines       20912    20984      +72     
==========================================
- Hits        19365    19349      -16     
- Misses       1547     1635      +88     
Impacted Files Coverage Δ
tests/test_function.py 25.30% <20.31%> (-74.70%) ⬇️
redis/cluster.py 91.93% <61.53%> (-0.51%) ⬇️
redis/commands/core.py 85.95% <75.00%> (-1.28%) ⬇️
redis/commands/json/__init__.py 97.56% <75.00%> (-2.44%) ⬇️
redis/commands/parser.py 88.40% <75.00%> (-1.92%) ⬇️
redis/commands/timeseries/__init__.py 94.73% <80.00%> (-5.27%) ⬇️
tests/test_commands.py 99.20% <90.90%> (-0.07%) ⬇️
redis/commands/cluster.py 94.87% <100.00%> (+0.04%) ⬆️
tests/test_bloom.py 99.54% <100.00%> (+<0.01%) ⬆️
tests/test_graph.py 90.62% <100.00%> (+0.06%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77df17...d323b92. Read the comment docs.

chayim and others added 7 commits February 27, 2022 13:08
* Add support for AUTH

* Fix linter error

* test fix

* fix test in cluster

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
…edis#2032)

Co-authored-by: Chayim <chayim@users.noreply.github.com>
* Add `items` parameter to `hset`

* Add test for `hset` with `items`

* Update CHANGES

* fix test_profile

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
* cluster support for functions

* fix test_list_on_cluster mark

* fix mark

* cluster unstable url

* fix

* fix cluster url

* skip tests

* linters

* linters
@dvora-h dvora-h merged commit 4dc48d6 into redis:master Mar 6, 2022
@dvora-h dvora-h deleted the command-docs branch March 10, 2022 11:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for COMMAND DOCS
5 participants