Skip to content

Add support for HSET items #2006

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Mar 6, 2022
Merged

Add support for HSET items #2006

merged 6 commits into from
Mar 6, 2022

Conversation

mdczaplicki
Copy link
Contributor

@mdczaplicki mdczaplicki commented Feb 22, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Is the changes added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Allow passing items to hset.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #2006 (604ae4c) into master (c5d19b8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   92.63%   92.63%   -0.01%     
==========================================
  Files         100      100              
  Lines       20921    20962      +41     
==========================================
+ Hits        19381    19418      +37     
- Misses       1540     1544       +4     
Impacted Files Coverage Δ
redis/commands/core.py 87.18% <100.00%> (ø)
tests/test_commands.py 99.27% <100.00%> (+<0.01%) ⬆️
tests/test_search.py 99.11% <100.00%> (+<0.01%) ⬆️
redis/commands/timeseries/__init__.py 94.73% <0.00%> (-5.27%) ⬇️
redis/commands/json/__init__.py 97.56% <0.00%> (-2.44%) ⬇️
redis/commands/parser.py 88.40% <0.00%> (-1.92%) ⬇️
redis/cluster.py 92.03% <0.00%> (-0.40%) ⬇️
redis/asyncio/client.py 90.45% <0.00%> (-0.18%) ⬇️
tests/test_timeseries.py 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d19b8...604ae4c. Read the comment docs.

@mdczaplicki mdczaplicki marked this pull request as ready for review February 22, 2022 14:23
@chayim chayim changed the title Add items to hset signature Add support for HSET items Feb 22, 2022
@chayim
Copy link
Contributor

chayim commented Feb 22, 2022

@mdczaplicki Well this is just awesome, and on the heels of 4.2.0rc1! Approved for 4.2.0rc1. Nice catch!

@chayim chayim self-requested a review February 22, 2022 14:39
@chayim chayim added the feature New feature label Feb 22, 2022
@chayim
Copy link
Contributor

chayim commented Feb 24, 2022

Oy @mdczaplicki sorry, I missed merging this into 4.2.0rc1. I've merged the latest master in, to make sure it plays nice - and we'll merge this in for 4.2.0rc2. Again, my apologies - that wasn't nice of me.

@mdczaplicki
Copy link
Contributor Author

mdczaplicki commented Feb 24, 2022 via email

@dvora-h dvora-h merged commit 6c798df into redis:master Mar 6, 2022
dvora-h added a commit to dvora-h/redis-py that referenced this pull request Mar 6, 2022
* Add `items` parameter to `hset`

* Add test for `hset` with `items`

* Update CHANGES

* fix test_profile

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
dvora-h added a commit that referenced this pull request Mar 6, 2022
* command docs

* Add support for AUTH (#1929)

* Add support for AUTH

* Fix linter error

* test fix

* fix test in cluster

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>

* Add support for JSON, TIMESERIES, BLOOM & GRAPH commands in cluster (#2032)

Co-authored-by: Chayim <chayim@users.noreply.github.com>

* Add support for HSET items (#2006)

* Add `items` parameter to `hset`

* Add test for `hset` with `items`

* Update CHANGES

* fix test_profile

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>

* Add cluster support for functions (#2016)

* cluster support for functions

* fix test_list_on_cluster mark

* fix mark

* cluster unstable url

* fix

* fix cluster url

* skip tests

* linters

* linters

* skip test

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: dogukanteber <47397379+dogukanteber@users.noreply.github.com>
Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: Marek Czaplicki <mdczaplicki@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants