-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update xsens root_link imu configuration file in order to publish correctly with iCubGazeboV2_7 #246
Conversation
Thanks @martinaxgloria ! Are you sure that this PR fixes #245 ? In particular, it is not clear to me how the measure of the IMU is published for the xsens root_link IMU in this case. |
Sorry @traversaro, I mean that with these changes the errors mentioned above disappear. I attach here the log: |
@@ -29,7 +29,6 @@ | |||
|
|||
<!-- INERTIAL SENSOR--> | |||
<xi:include href="wrappers/inertials/head-inertials_wrapper.xml" /> | |||
<!-- NOT USED RIGHT NOW | |||
<xi:include href="wrappers/inertials/waist-inertials_wrapper.xml" /> --> | |||
<xi:include href="wrappers/inertials/waist-inertials_wrapper.xml" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is not breaking the simulation for models that are not 2.7 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, nice catch I didn't notice it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right. I will restore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See ef49e19#r1311744863 .
Include the wrapper for xsens imu Restore icub.xml
…rsserver' in gazebo_icub_xsens_inertial.ini
a90c0f3
to
1730860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we can use the subdevice
clause I think it is a good compromise
Did you try if this is actually working? I am afraid we are hardcoding inertial in gazebo-yarp-plugins . |
Actually, we should be good to go : https://github.com/robotology/gazebo-yarp-plugins/blob/0fd9300b583267c7bff4fb2be7fe82700ddeb613/plugins/imu/src/IMU.cc#L98 , but perhaps we should put this in the |
Maybe we need to set |
Actually, this warning message is printed out but it doesn't cause the yarprobotinterface to close. I attach here the log: And xsens data were published correctly on the port. |
Perfect! |
I opened #247 to track a proper solution. |
This PR fixes #245
The updates introduced with #231 don't affect the xsens on the root link. This causes errors when iCubGazeboV2_7 model is loaded on gazebo: