Get theme as disk #2421
Closed
Get theme as disk #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a new version of Sage in the pipeline. The most significant change is the introduction of Acorn. I'll release more information about Acorn as it nears completion. TODO - [ ] Restructure templates (@retlehs) - [ ] Code splitting (@austinpray, @QWp6t, @swalkinshaw) - [ ] WooCommerce compatibility (@QWp6t, @retlehs) - [ ] API for build process (possibly extend Laravel Mix) (@QWp6t, @austinpray) - [ ] Acorn - roots/acorn#1 (@QWp6t) - [ ] Documentation Sage 10 and Acorn are both still works in progress so you should definitely not start any projects with them in their current state unless you're willing to do an inordinate amount of debugging and go through the hassle of keeping up with updates as we push them.
Enable preflight by default Bump version to 10.0.0 in package.json and style.css Change PHP requirement to 7.1.3 Upgrade roots/sage-installer Remove deprecated qwp6t/acorn repository from composer.json Add some sane optimizations to composer.json Remove excessive linebreaks from helpers.php Make config linebreaking uniform Add missing space to ! conditionals to stay consistent with PSR-1/2 Update the file structure in README.md and add the new sponsor Revert to shorthand @php() Add aside markup to sidebar and wrap it in @hasSection Add a document wrapper Add ARIA roles to the document, main, aside, header, nav, and footer wrappers Change entry-meta conditional in content-search.blade.php to an @includeWhen Add some sane linebreaks throughout the views and codebase to increase readability Add docblocks to the example Title.php composer
Remove roots/wp-blade-check until we decide on where to put it Only enable preflight when not in production
Sage 10 Cleanup
Clean up and refactor starter styles Remove autoload from styles/scripts Remove $ import on customizer.js as Mix autoload will handle that Fix conditional on comments.blade.php Bump PHP version to 7.1.3 on Travis Remove unnecessary fields in package.json as it will never be published Rename main.css/main.js to app.css/app.js Automatically remove Blade cache when theme is activated, changed, or removed
Fix typo in lint:scripts Restore double quotes in list:styles Add missing space after ! in body_class filter Change add_editor_style() back to app.css for now Add missing finalize() to about.js Uncomment Bootstrap Navbar Fix (although I do not know if its still needed) Add linebreak to li in comments.blade.php Bump Node.js version in README Restore my initial .editorconfig change Make app.js comments uniform Remove sage-installer (will be replaced) Bump dependencies for good measure
Move Sage 10 to Laravel Mix
This lets us run related scripts together pretty easily since we can use glob patterns (e.g. `lint:*` — `**` is supported too). You can either run scripts sequentially with `run-s` or in parallel with `run-p`. See: https://github.com/mysticatea/npm-run-all
This way lint issues for the scripts doesn’t block the styles from being linted.
* Break up `build:production`
* Refine `start` script to call `build` but using `--watch`
* Since the base command is the same, this makes it easier to
maintain.
* Use run-s for `test` script for consistency.
The only thing that differs between `build` and `build:production` is the Node environment variable. We can use `run-s build:mix` preceeded by the correspinding environment setting.
We need to pass `--watch` to the `build:mix` not `build`. Also, this means we need to set the Node environment beforehand since `build:mix` doesn’t have that.
`dist` needs to exist for HMR to work since it looks for `dist/hot`. This means we should probably build once before starting HMR. This also renames `build:mix` to just `mix` to keep a consistent naming scheme.
Add npm-run-all
Add app.name to configuration Add a ServiceProvider stub Add missing trailing commas to config Remove automatic Blade cache removal action as it is no longer necessary Clean up .gitignore Clean up JavaScript docblocks Remove home.js example Remove leftover Sage 9 information from README
Continued Sage 10 cleanup
Since views are in a predictable location within the theme, this might be handy. A side effect of adding this is that generated views are now cleared on every production build, which might be a good thing. If not, it’s not hard to change.
Since Mix uses the `webpack.mix.js` path as the webpack context and doesn’t let us change the context, having a helper can make it easier to add new assets. It also provides a single source of truth for the assets source directory. Also, this adds a `public` function which just makes it easy for setting the `to` path in the `copyDirectory` task. By including the definitions of these functions within the `webpack.mix.js` file itself it makes it clear to Sage users that they are not a part of Mix.
* Breaking Change: Bump required PHP version to 7.2 * chore(deps): Bump dependencies * fix(app): Change app.env and app.debug default values (important*) * chore(deps-dev): Add filp/whoops to required-dev * chore(ci): Remove php-71 from CircleCI
- Refactor default styles and scripts - Clean up default view markup - Change `Title.php` to `Post.php` to suggest a more organized workflow (Supersedes roots#2320) - Create an `App` composer to show an example of a global variable - Add `align-wide` and `responsive-embeds` to `add_theme_support` by default - Remove deprecated `soil-jquery-cdn` from `add_theme_support` - Clean up docblocks project-wide - Update linting to match the latest PSR-12 standards (e.g. the license docblocks) - Add an appropriate `#app` wrapper to make the project ready for frameworks like Vue - Add `laravel-mix-purgecss` for purgeCSS in production - Add `laravel-mix-copy-watched` for asset watching & versioning - Add `laravel-mix-wp-blocks` to handle compiling blocks - Reduce the footprint of the default `webpack.mix.js` - Append filetypes to asset names - Add default block editor assets - Add handling for the WordPress asset manifest - Remove visual editor styling (Fixes roots#2269) - Add sensible default styles and folders - Remove unused `phpcs.xml` - Move `sage-directives` and `sage-svg` to suggests - Bump dependencies - Add Brandon Nifong as an author - Change license URI to https - Remove unused function namespaces from setup.php - Append filetypes to asset names - Add default block editor assets - Add handling for the WordPress asset manifest - Ignore dist when running phpcs - Change the search input class the the WP default
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.3.1 to 4.4.1. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](twbs/bootstrap@v4.3.1...v4.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint](https://github.com/eslint/eslint) from 6.6.0 to 6.7.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.6.0...v6.7.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.23.3 to 1.23.7. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](sass/dart-sass@1.23.3...1.23.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* adds alternate button style and super basic starter css * Adds transition variable * Add bootstrap max-width to editor-styles * updates button scss, editor wrapper scss, and registration * rename is-style-ghost to is-style-outline * simplify structure and cleanup css * Protect Ben Word's typographic holdings * Remove scoping from .has-xyz-color classes * Restore scss partial import structure * rename partials, move color util, apply bootstrap font * alphabetical selectors ¯\_(ツ)_/¯
Bumps [stylelint](https://github.com/stylelint/stylelint) from 11.1.1 to 12.0.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](stylelint/stylelint@11.1.1...12.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [squizlabs/php_codesniffer](https://github.com/squizlabs/PHP_CodeSniffer) from 3.5.2 to 3.5.3. - [Release notes](https://github.com/squizlabs/PHP_CodeSniffer/releases) - [Commits](squizlabs/PHP_CodeSniffer@3.5.2...3.5.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Update theme structure + files in README
feat(stylelint): Set `at-rule-empty-line-before` to `null` to allow sane seperation of imports
The theme disk is too difficult to get to. Fix it! I don't really intend to use the URL thing with it, it's just to have easy access to the Storage facade to write files when a folder isn't there. Maybe there's a better way to do this, but I've been using it and haven't found a downside; maybe someone has a better way!
QWp6t
requested changes
Aug 12, 2020
| 'sage' => [ | ||
| 'driver' => 'local', | ||
| 'root' => get_theme_file_path(), | ||
| 'url' => site_url(), |
There was a problem hiding this comment.
This should be get_theme_file_uri() to be consistent with get_theme_file_path().
well, this destroyed this PR. do you mind re-submitting this against master now that sage 10 is in the main branch? |
Log1x
added a commit
that referenced
this pull request
Aug 20, 2020
|
Added in #2520 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme disk is too difficult to get to. Fix it!
I don't really intend to use the URL thing with it, it's just to have easy access to the Storage facade to write files when a folder isn't there. Maybe there's a better way to do this, but I've been using it and haven't found a downside; maybe someone has a better way!